From: Dave Martin <dave.martin@linaro.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: linux-kernel@vger.kernel.org, Dave Martin <dave.martin@linaro.org>
Subject: [PATCH 1/1] perf symbols: ignore mapping symbols on ARM
Date: Mon, 9 Aug 2010 12:21:18 +0100 [thread overview]
Message-ID: <1281352878-8735-2-git-send-email-dave.martin@linaro.org> (raw)
In-Reply-To: <1281352878-8735-1-git-send-email-dave.martin@linaro.org>
Applies to linux-2.6-tip/master or acme/perf-core
ARM ELF files use symbols with special names $a, $t, $d to
identify regions of ARM code, Thumb code and data within code
sections. This can cause confusing output from the perf tools,
especially for partially stripped binaries, or binaries
containing user-added zero-sized symbols (which may occur in
hand-written assembler which hasn't been fully annotated with
.size directives).
This patch filters out these symbols at load time.
Signed-off-by: Dave Martin <dave.martin@linaro.org>
---
tools/perf/util/symbol.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index b6f5970..1a36773 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1079,6 +1079,16 @@ static int dso__load_sym(struct dso *self, struct map *map, const char *name,
if (!is_label && !elf_sym__is_a(&sym, map->type))
continue;
+ /* Reject ARM ELF "mapping symbols": these aren't unique and
+ * don't identify functions, so will confuse the profile
+ * output: */
+ if (ehdr.e_machine == EM_ARM) {
+ if (!strcmp(elf_name, "$a") ||
+ !strcmp(elf_name, "$d") ||
+ !strcmp(elf_name, "$t"))
+ continue;
+ }
+
if (opdsec && sym.st_shndx == opdidx) {
u32 offset = sym.st_value - opdshdr.sh_addr;
u64 *opd = opddata->d_buf + offset;
--
1.7.0.4
next prev parent reply other threads:[~2010-08-09 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 11:21 [PATCH 0/1] perf symbols: ignore mapping symbols on ARM Dave Martin
2010-08-09 11:21 ` Dave Martin [this message]
2010-08-09 14:53 ` [PATCH 1/1] " Arnaldo Carvalho de Melo
2010-08-11 7:41 ` [tip:perf/core] perf symbols: Ignore " tip-bot for Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281352878-8735-2-git-send-email-dave.martin@linaro.org \
--to=dave.martin@linaro.org \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.