* [PATCH] staging: adis16255: fix sysfs leak
@ 2010-08-11 8:00 ` Kulikov Vasiliy
0 siblings, 0 replies; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-08-11 8:00 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Matthias Brugger, Mike Frysinger, devel,
linux-kernel
Original code does not call sysfs_remove_group() on error. This can lead
to NULL dereference.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/adis16255/adis16255.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/adis16255/adis16255.c b/drivers/staging/adis16255/adis16255.c
index c3e6a4d..8d4d7cb 100644
--- a/drivers/staging/adis16255/adis16255.c
+++ b/drivers/staging/adis16255/adis16255.c
@@ -406,12 +406,14 @@ static int __devinit spi_adis16255_probe(struct spi_device *spi)
status = spi_adis16255_bringup(spiadis);
if (status != 0)
- goto irq_err;
+ goto sysfs_err;
dev_info(&spi->dev, "spi_adis16255 driver added!\n");
return status;
+sysfs_err:
+ sysfs_remove_group(&spiadis->spi->dev.kobj, &adis16255_attr_group);
irq_err:
free_irq(spiadis->irq, spiadis);
gpio_err:
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] staging: adis16255: fix sysfs leak
@ 2010-08-11 8:00 ` Kulikov Vasiliy
0 siblings, 0 replies; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-08-11 8:00 UTC (permalink / raw)
To: kernel-janitors
Cc: Greg Kroah-Hartman, Matthias Brugger, Mike Frysinger, devel,
linux-kernel
Original code does not call sysfs_remove_group() on error. This can lead
to NULL dereference.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/staging/adis16255/adis16255.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/adis16255/adis16255.c b/drivers/staging/adis16255/adis16255.c
index c3e6a4d..8d4d7cb 100644
--- a/drivers/staging/adis16255/adis16255.c
+++ b/drivers/staging/adis16255/adis16255.c
@@ -406,12 +406,14 @@ static int __devinit spi_adis16255_probe(struct spi_device *spi)
status = spi_adis16255_bringup(spiadis);
if (status != 0)
- goto irq_err;
+ goto sysfs_err;
dev_info(&spi->dev, "spi_adis16255 driver added!\n");
return status;
+sysfs_err:
+ sysfs_remove_group(&spiadis->spi->dev.kobj, &adis16255_attr_group);
irq_err:
free_irq(spiadis->irq, spiadis);
gpio_err:
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-11 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-11 8:00 [PATCH] staging: adis16255: fix sysfs leak Kulikov Vasiliy
2010-08-11 8:00 ` Kulikov Vasiliy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.