From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: i.MX SDMA support Date: Wed, 11 Aug 2010 11:24:08 +0100 Message-ID: <1281522248.3080.40.camel@odin> References: <20100809091157.GC20065@pengutronix.de> <1281350823.3035.54.camel@odin> <20100809121956.GA27749@pengutronix.de> <64008892-3D75-4309-A623-CCE9B335F77F@opensource.wolfsonmicro.com> <20100810131527.GK27749@pengutronix.de> <1281449263.3059.53.camel@odin> <20100811084430.GO27749@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f51.google.com (mail-ww0-f51.google.com [74.125.82.51]) by alsa0.perex.cz (Postfix) with ESMTP id 3873D24589 for ; Wed, 11 Aug 2010 12:24:12 +0200 (CEST) Received: by wwa36 with SMTP id 36so2860942wwa.20 for ; Wed, 11 Aug 2010 03:24:11 -0700 (PDT) In-Reply-To: <20100811084430.GO27749@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Sascha Hauer Cc: "alsa-devel@alsa-project.org" , Mark Brown List-Id: alsa-devel@alsa-project.org On Wed, 2010-08-11 at 10:44 +0200, Sascha Hauer wrote: > On Tue, Aug 10, 2010 at 03:07:43PM +0100, Liam Girdwood wrote: > > On Tue, 2010-08-10 at 15:15 +0200, Sascha Hauer wrote: > > > > > I just looked at the i.MX part in the multi-component update and this > > > is currently far from being in a working state, so there's still some > > > work to do before thinking about possible conflicts... > > > > Ok, I don't think it's that far off. Everything builds for i.MX and all > > components should register. The part I can't test is the component > > probe() and playback/capture. > > > > Have you seen an oops ? > > > > Besides the patch that I just sent I get a null pointer deref without > the following patch. I couldn't find who should set > codec->ac97->bus->card, but it's null when I get here. Is this an i.MX > fault or is there something else missing here? > That is set in the AC97 core and did work at the time of the RFC (when I could test on my now non working Zylonite). Although since the RFC there had been changes to use the dev_name for component binding and a little re-reordering on the bind (and would have affected this piece of code too). > Sascha > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index 81a77e0..eddb26e 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -312,7 +312,7 @@ static int soc_ac97_dev_register(struct snd_soc_codec *codec) > codec->ac97->dev.release = soc_ac97_device_release; > > dev_set_name(&codec->ac97->dev, "%d-%d:%s", > - codec->ac97->bus->card->number, 0, codec->name); > + codec->snd_card->number, 0, codec->name); > err = device_register(&codec->ac97->dev); > if (err < 0) { > snd_printk(KERN_ERR "Can't register ac97 bus\n"); This looks good to me, as card will be set after the device_register. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk