All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: possible fix for buffer underruns on msm7k alsa driver
Date: Sun, 15 Aug 2010 19:58:01 +0200	[thread overview]
Message-ID: <1281895083-24953-1-git-send-email-GNUtoo@no-log.org> (raw)
In-Reply-To: <20100815112925.GA11017@sirena.org.uk>


>Your mail is very lengthy and something seems to have stripped all the
>indentation from the source code you've pasted.  This all makes it
>extremely hard to read, and the fact that it's discussing drivers which
>have never been sent upstream doesn't help either.
>
>The last time I looked at MSM audio drivers I noticed several abuses of
>APIs in there which make me concerned about the robustness of any
>changes that one might make to the code.  I've no idea if this was the
>same set of drivers as you are looking at, it's really unfortunate that
>work on these drivers appears so fragmented.

The reference code source is at:
http://gitorious.org/htc-msm-2-6-32/leviathan-incoming/trees/android-msm-2.6.32-rebase/sound/soc/msm

And the audio patch that I rebased were attached
The most important one is that one:
[PATCH 2/4] sound: soc: msm7k: improve buffer underrun issue

There are only 2 patches.

  reply	other threads:[~2010-08-15 17:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-14 18:29 possible fix for buffer underruns on msm7k alsa driver Denis 'GNUtoo' Carikli
2010-08-15 11:29 ` Mark Brown
2010-08-15 17:58   ` Denis 'GNUtoo' Carikli [this message]
2010-08-15 18:08     ` [PATCH 1/4] sound: soc: msm7k: add mmap interface Denis 'GNUtoo' Carikli
2010-08-15 18:08     ` [PATCH 2/4] sound: soc: msm7k: improve buffer underrun issue Denis 'GNUtoo' Carikli
2010-08-15 19:55     ` possible fix for buffer underruns on msm7k alsa driver Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281895083-24953-1-git-send-email-GNUtoo@no-log.org \
    --to=gnutoo@no-log.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.