All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Dan Carpenter <error27@gmail.com>, Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 4/6] rocket: add a mutex_unlock()
Date: Mon, 23 Aug 2010 21:24:04 -0700	[thread overview]
Message-ID: <1282623846-17050-4-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20100824040508.GC16749@kroah.com>

From: Dan Carpenter <error27@gmail.com>

This path needs a mutex_unlock().  This is stuff from the bkl to mutex
transition.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/char/rocket.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c
index 79c3bc6..7c79d24 100644
--- a/drivers/char/rocket.c
+++ b/drivers/char/rocket.c
@@ -1244,6 +1244,7 @@ static int set_config(struct tty_struct *tty, struct r_port *info,
 		}
 		info->flags = ((info->flags & ~ROCKET_USR_MASK) | (new_serial.flags & ROCKET_USR_MASK));
 		configure_r_port(tty, info, NULL);
+		mutex_unlock(&info->port.mutex);
 		return 0;
 	}
 
-- 
1.7.2


  parent reply	other threads:[~2010-08-24  4:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-24  4:05 [GIT PATCH] TTY fixes for .36-rc2 Greg KH
2010-08-24  4:24 ` [PATCH 1/6] serial: print early console device address in hex Greg Kroah-Hartman
2010-08-24  4:24 ` [PATCH 2/6] ip2: remove unneeded NULL check Greg Kroah-Hartman
2010-08-24  4:24 ` [PATCH 3/6] ip2: return -EFAULT on copy_to_user errors Greg Kroah-Hartman
2010-08-24  4:24 ` Greg Kroah-Hartman [this message]
2010-08-24  4:24 ` [PATCH 5/6] synclink: add mutex_unlock() on error path Greg Kroah-Hartman
2010-08-24  4:24 ` [PATCH 6/6] 68328serial: check return value of copy_*_user() instead of access_ok() Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282623846-17050-4-git-send-email-gregkh@suse.de \
    --to=gregkh@suse.de \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.