[PATCH 2/4] Support text mode sms sending and receiving

[PATCH 2/4] Support text mode sms sending and receiving

[Yong Su]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

---
 gatchat/gatchat.h |   23 +++++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)

diff --git a/gatchat/gatchat.h b/gatchat/gatchat.h
index f61fe53..c2aca58 100644
--- a/gatchat/gatchat.h
+++ b/gatchat/gatchat.h
@@ -137,6 +137,29 @@ gboolean g_at_chat_set_wakeup_command(GAtChat *chat, const char *cmd,
 void g_at_chat_add_terminator(GAtChat *chat, char *terminator,
 				int len, gboolean success);
 
+/**
+ * Send AT command with length, such as SMS text mode which contains 0x00 or 0x0A, 0x0D
+ */
+guint g_at_chat_send_with_len(GAtChat *chat, const char *cmd, int cmdlen,
+		const char **prefix_list, GAtResultFunc func,
+		gpointer user_data, GDestroyNotify notify);
+
+/**
+ * Call back function to handle receive Text Mode SMS
+ * Get the message content length, include 0x1A or 0x001A
+ */
+typedef int (*GAtExpectMsgLenFunc)(const char* line);
+
+/**
+ * Modify from g_at_chat_register, add parameter expect_msglen_func
+ */
+guint g_at_chat_register_with_func(GAtChat *chat, const char *prefix,
+				GAtNotifyFunc func, gboolean expect_pdu,
+				GAtExpectMsgLenFunc expect_msglen_func,
+				gpointer user_data, GDestroyNotify notify);
+
+
+
 #ifdef __cplusplus
 }
 #endif
-- 
1.6.3.3

Re: [PATCH 2/4] Support text mode sms sending and receiving

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi Yong,

> ---
>  gatchat/gatchat.h |   23 +++++++++++++++++++++++
>  1 files changed, 23 insertions(+), 0 deletions(-)

so Denis has to give a final say on yes or no to these patches, but in
general gatchat.[ch] have to be submitted together. This applies to the
whole project.

Splitting patches into smaller pieces is not splitting them into one
patch per file. Split them into logical chunks and preferable that non
of them break the compilation.

Regards

Marcel