* [PATCH] nl80211: fix missing nesting
@ 2010-08-24 10:15 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2010-08-24 10:15 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless, Philip A. Prindeville, Philip Prindeville
From: Johannes Berg <johannes.berg@intel.com>
commit 95a6ccbb46c70cff376684c752831c014c87029d
Author: Johannes Berg <johannes.berg@intel.com>
Date: Thu Aug 12 15:38:38 2010 +0200
cfg80211/mac80211: extensible frame processing
introduced a netlink bug that caused parsing errors
in userspace because it forgot to close a nesting,
which would advertise a nesting length of zero to
userspace, which then completely threw off parsing
and led to
Illegal nla->nla_type == 0
being printed by libnl.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/wireless/nl80211.c | 2 ++
1 file changed, 2 insertions(+)
--- wireless-testing.orig/net/wireless/nl80211.c 2010-08-24 12:11:16.000000000 +0200
+++ wireless-testing/net/wireless/nl80211.c 2010-08-24 12:11:21.000000000 +0200
@@ -636,6 +636,8 @@ static int nl80211_send_wiphy(struct sk_
nla_nest_end(msg, nl_ftypes);
}
+ nla_nest_end(msg, nl_ifs);
+
nl_ifs = nla_nest_start(msg, NL80211_ATTR_RX_FRAME_TYPES);
if (!nl_ifs)
goto nla_put_failure;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-08-24 10:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-24 10:15 [PATCH] nl80211: fix missing nesting Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.