Re: Small series to enable OpRegion->VBT

[Adam Jackson <ajax@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1369 bytes --]

On Tue, 2010-08-24 at 15:37 +0100, Chris Wilson wrote:
> On Tue, 24 Aug 2010 10:22:48 -0400, Adam Jackson <ajax@redhat.com> wrote:
> > I'd be a little more comfortable with this series if we tried to find
> > VBT in VBIOS first.  The way around you have it in patch 3 we'll likely
> > be changing behaviour on existing machines, since we've not been paying
> > any attention to what OpRegion's VBT contains before now.  I mean, I'm
> > not going to insist on it, but I'll reserve the right to say I told you
> > so.
> 
> That would be the conservative approach. The docs are adamant that
> OpRegion should be used in preference to any legacy approach. But nobody
> reads those docs, at least not whilst writing the BIOS or during review.

If only there were some kind of firmware verification kit so vendors
would be able to test that they're not violating our assumptions.

http://linuxfirmwarekit.org/

Wonder whatever happened to that?

> One of the goals here is to solve the mystery of what happens to the VBT
> on docking and whether new devices appear via the OpRegion, through the
> ROM or never. If you do have one of the affected HP systems, can you at
> try the patch and grab the /sys/kernel/debug/dri/0/i915_opregion before
> and after docking?

I have a few Lenovae that update VBT on dock, yeah, I'll give it a shot.

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx