From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> To: mst@redhat.com Cc: joro@8bytes.org, blauwirbel@gmail.com, paul@codesourcery.com, avi@redhat.com, anthony@codemonkey.ws, av1474@comtv.ru, yamahata@valinux.co.jp, kvm@vger.kernel.org, qemu-devel@nongnu.org, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> Subject: [PATCH 0/7] AMD IOMMU emulation patchset v4 Date: Sat, 28 Aug 2010 17:54:51 +0300 [thread overview] Message-ID: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> (raw) Hi, I rebased my work on mst's PCI tree and, hopefully, fixed issues raised by others. Here's a summary of the changes: - made it apply to mst/pci - moved some AMD IOMMU stuff in a reset handler - dropped range_covers_range() (wasn't the same as ranges_overlap(), but the latter was better anyway) - used 'expand' to remove tabs in pci_regs.h before applying the useful changes - fixed the endianness mistake spotted by Blue (though ldq_phys wasn't needed) As for Anthony's suggestion to simply sed-convert all devices, I'd rather go through them one at a time and do it manually. 'sed' would not only mess indentation, but also it isn't straightforward to get the 'PCIDevice *' you need to pass to the pci_* helpers. (I'll try to focus on conversion next so we can poison the old stuff.) I also added (read "spelled it out myself") malc's ACK to the ac97 patch. Nothing changed since his last review. Please have a look and merge if you like it. Thanks, Eduard Eduard - Gabriel Munteanu (7): pci: expand tabs to spaces in pci_regs.h pci: memory access API and IOMMU support AMD IOMMU emulation ide: use the PCI memory access interface rtl8139: use the PCI memory access interface eepro100: use the PCI memory access interface ac97: use the PCI memory access interface Makefile.target | 2 +- dma-helpers.c | 46 ++- dma.h | 21 +- hw/ac97.c | 6 +- hw/amd_iommu.c | 663 ++++++++++++++++++++++++++ hw/eepro100.c | 86 ++-- hw/ide/core.c | 15 +- hw/ide/internal.h | 39 ++ hw/ide/macio.c | 4 +- hw/ide/pci.c | 7 + hw/pc.c | 2 + hw/pci.c | 185 ++++++++- hw/pci.h | 74 +++ hw/pci_ids.h | 2 + hw/pci_internals.h | 12 + hw/pci_regs.h | 1331 ++++++++++++++++++++++++++-------------------------- hw/rtl8139.c | 99 +++-- qemu-common.h | 1 + 18 files changed, 1827 insertions(+), 768 deletions(-) create mode 100644 hw/amd_iommu.c rewrite hw/pci_regs.h (90%)
WARNING: multiple messages have this Message-ID (diff)
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro> To: mst@redhat.com Cc: kvm@vger.kernel.org, joro@8bytes.org, qemu-devel@nongnu.org, blauwirbel@gmail.com, yamahata@valinux.co.jp, paul@codesourcery.com, Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>, avi@redhat.com Subject: [Qemu-devel] [PATCH 0/7] AMD IOMMU emulation patchset v4 Date: Sat, 28 Aug 2010 17:54:51 +0300 [thread overview] Message-ID: <1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro> (raw) Hi, I rebased my work on mst's PCI tree and, hopefully, fixed issues raised by others. Here's a summary of the changes: - made it apply to mst/pci - moved some AMD IOMMU stuff in a reset handler - dropped range_covers_range() (wasn't the same as ranges_overlap(), but the latter was better anyway) - used 'expand' to remove tabs in pci_regs.h before applying the useful changes - fixed the endianness mistake spotted by Blue (though ldq_phys wasn't needed) As for Anthony's suggestion to simply sed-convert all devices, I'd rather go through them one at a time and do it manually. 'sed' would not only mess indentation, but also it isn't straightforward to get the 'PCIDevice *' you need to pass to the pci_* helpers. (I'll try to focus on conversion next so we can poison the old stuff.) I also added (read "spelled it out myself") malc's ACK to the ac97 patch. Nothing changed since his last review. Please have a look and merge if you like it. Thanks, Eduard Eduard - Gabriel Munteanu (7): pci: expand tabs to spaces in pci_regs.h pci: memory access API and IOMMU support AMD IOMMU emulation ide: use the PCI memory access interface rtl8139: use the PCI memory access interface eepro100: use the PCI memory access interface ac97: use the PCI memory access interface Makefile.target | 2 +- dma-helpers.c | 46 ++- dma.h | 21 +- hw/ac97.c | 6 +- hw/amd_iommu.c | 663 ++++++++++++++++++++++++++ hw/eepro100.c | 86 ++-- hw/ide/core.c | 15 +- hw/ide/internal.h | 39 ++ hw/ide/macio.c | 4 +- hw/ide/pci.c | 7 + hw/pc.c | 2 + hw/pci.c | 185 ++++++++- hw/pci.h | 74 +++ hw/pci_ids.h | 2 + hw/pci_internals.h | 12 + hw/pci_regs.h | 1331 ++++++++++++++++++++++++++-------------------------- hw/rtl8139.c | 99 +++-- qemu-common.h | 1 + 18 files changed, 1827 insertions(+), 768 deletions(-) create mode 100644 hw/amd_iommu.c rewrite hw/pci_regs.h (90%)
next reply other threads:[~2010-08-28 14:56 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-08-28 14:54 Eduard - Gabriel Munteanu [this message] 2010-08-28 14:54 ` [Qemu-devel] [PATCH 0/7] AMD IOMMU emulation patchset v4 Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [PATCH 1/7] pci: expand tabs to spaces in pci_regs.h Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-31 20:29 ` Michael S. Tsirkin 2010-08-31 20:29 ` [Qemu-devel] " Michael S. Tsirkin 2010-08-31 22:58 ` Eduard - Gabriel Munteanu 2010-08-31 22:58 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-01 10:39 ` Michael S. Tsirkin 2010-09-01 10:39 ` [Qemu-devel] " Michael S. Tsirkin 2010-08-28 14:54 ` [PATCH 2/7] pci: memory access API and IOMMU support Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 5:28 ` Michael S. Tsirkin 2010-09-02 5:28 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-02 8:40 ` Eduard - Gabriel Munteanu 2010-09-02 8:40 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 9:49 ` Michael S. Tsirkin 2010-09-02 9:49 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-04 9:01 ` Blue Swirl 2010-09-04 9:01 ` [Qemu-devel] " Blue Swirl 2010-09-05 7:10 ` Michael S. Tsirkin 2010-09-05 7:10 ` [Qemu-devel] " Michael S. Tsirkin 2010-08-28 14:54 ` [PATCH 3/7] AMD IOMMU emulation Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-28 15:58 ` Blue Swirl 2010-08-28 15:58 ` [Qemu-devel] " Blue Swirl 2010-08-28 21:53 ` Eduard - Gabriel Munteanu 2010-08-28 21:53 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-29 20:37 ` Blue Swirl 2010-08-29 20:37 ` [Qemu-devel] " Blue Swirl 2010-08-30 3:07 ` [Qemu-devel] " Isaku Yamahata 2010-08-30 3:07 ` Isaku Yamahata 2010-08-30 5:54 ` Eduard - Gabriel Munteanu 2010-08-30 5:54 ` Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [PATCH 4/7] ide: use the PCI memory access interface Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 5:19 ` Michael S. Tsirkin 2010-09-02 5:19 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-02 9:12 ` Eduard - Gabriel Munteanu 2010-09-02 9:12 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 9:58 ` Michael S. Tsirkin 2010-09-02 9:58 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-02 15:01 ` Eduard - Gabriel Munteanu 2010-09-02 15:01 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-02 15:24 ` Avi Kivity 2010-09-02 15:24 ` [Qemu-devel] " Avi Kivity 2010-09-02 15:39 ` Michael S. Tsirkin 2010-09-02 15:39 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-02 16:07 ` Avi Kivity 2010-09-02 16:07 ` [Qemu-devel] " Avi Kivity 2010-09-02 15:31 ` Michael S. Tsirkin 2010-09-02 15:31 ` [Qemu-devel] " Michael S. Tsirkin 2010-08-28 14:54 ` [PATCH 5/7] rtl8139: " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [PATCH 6/7] eepro100: " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [PATCH 7/7] ac97: " Eduard - Gabriel Munteanu 2010-08-28 14:54 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-28 16:00 ` [PATCH 0/7] AMD IOMMU emulation patchset v4 Blue Swirl 2010-08-28 16:00 ` [Qemu-devel] " Blue Swirl 2010-08-29 9:55 ` Joerg Roedel 2010-08-29 9:55 ` [Qemu-devel] " Joerg Roedel 2010-08-29 20:44 ` Blue Swirl 2010-08-29 20:44 ` [Qemu-devel] " Blue Swirl 2010-08-29 22:08 ` [PATCH 2/7] pci: memory access API and IOMMU support Eduard - Gabriel Munteanu 2010-08-29 22:08 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-08-29 22:11 ` Eduard - Gabriel Munteanu 2010-08-29 22:11 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-01 20:10 ` [Qemu-devel] " Stefan Weil 2010-09-01 20:10 ` Stefan Weil 2010-09-02 6:00 ` Michael S. Tsirkin 2010-09-02 6:00 ` Michael S. Tsirkin 2010-09-02 9:08 ` Eduard - Gabriel Munteanu 2010-09-02 9:08 ` Eduard - Gabriel Munteanu 2010-09-02 13:24 ` Anthony Liguori 2010-09-02 13:24 ` Anthony Liguori 2010-09-02 8:51 ` Eduard - Gabriel Munteanu 2010-09-02 8:51 ` Eduard - Gabriel Munteanu 2010-09-02 16:05 ` Stefan Weil 2010-09-02 16:05 ` Stefan Weil 2010-09-02 16:14 ` Eduard - Gabriel Munteanu 2010-09-02 16:14 ` Eduard - Gabriel Munteanu 2010-09-13 20:01 ` [PATCH RFC] dma_rw.h (was Re: [PATCH 0/7] AMD IOMMU emulation patchset v4) Michael S. Tsirkin 2010-09-13 20:01 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-13 20:45 ` Anthony Liguori 2010-09-13 20:45 ` Anthony Liguori 2010-09-16 7:12 ` Eduard - Gabriel Munteanu 2010-09-16 7:12 ` Eduard - Gabriel Munteanu 2010-09-16 9:35 ` Michael S. Tsirkin 2010-09-16 9:35 ` Michael S. Tsirkin 2010-09-16 7:06 ` Eduard - Gabriel Munteanu 2010-09-16 7:06 ` [Qemu-devel] " Eduard - Gabriel Munteanu 2010-09-16 9:20 ` Michael S. Tsirkin 2010-09-16 9:20 ` [Qemu-devel] " Michael S. Tsirkin 2010-09-16 11:15 ` Eduard - Gabriel Munteanu 2010-09-16 11:15 ` [Qemu-devel] " Eduard - Gabriel Munteanu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1283007298-10942-1-git-send-email-eduard.munteanu@linux360.ro \ --to=eduard.munteanu@linux360.ro \ --cc=anthony@codemonkey.ws \ --cc=av1474@comtv.ru \ --cc=avi@redhat.com \ --cc=blauwirbel@gmail.com \ --cc=joro@8bytes.org \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=paul@codesourcery.com \ --cc=qemu-devel@nongnu.org \ --cc=yamahata@valinux.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.