From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47650 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqLJ0-0007ke-9k for qemu-devel@nongnu.org; Tue, 31 Aug 2010 03:30:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqLIz-0003nb-9q for qemu-devel@nongnu.org; Tue, 31 Aug 2010 03:30:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5042) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqLIz-0003nQ-3c for qemu-devel@nongnu.org; Tue, 31 Aug 2010 03:30:53 -0400 From: Jes.Sorensen@redhat.com Date: Tue, 31 Aug 2010 09:30:38 +0200 Message-Id: <1283239838-20349-7-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1283239838-20349-1-git-send-email-Jes.Sorensen@redhat.com> References: <1283239838-20349-1-git-send-email-Jes.Sorensen@redhat.com> Subject: [Qemu-devel] [PATCH 6/6] load_multiboot(): get_image_size() returns int List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, Jes.Sorensen@redhat.com From: Jes Sorensen Do not store return of get_image_size() in a uint32_t as it makes it impossible to detect error returns from get_image_size. Signed-off-by: Jes Sorensen --- hw/multiboot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/multiboot.c b/hw/multiboot.c index dc980e6..f9097a2 100644 --- a/hw/multiboot.c +++ b/hw/multiboot.c @@ -252,7 +252,7 @@ int load_multiboot(void *fw_cfg, do { char *next_space; - uint32_t mb_mod_length; + int mb_mod_length; uint32_t offs = mbs.mb_buf_size; next_initrd = strchr(initrd_filename, ','); -- 1.7.2.2