From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Weidong Han <weidong.han@intel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: RE: xl fails to work with some command
Date: Tue, 31 Aug 2010 11:07:27 +0100 [thread overview]
Message-ID: <1283249247.12544.9361.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1008311038320.18383@kaball-desktop>
On Tue, 2010-08-31 at 10:40 +0100, Stefano Stabellini wrote:
> On Tue, 31 Aug 2010, Weidong Han wrote:
> > > As stated above, xl doesn't know how to FLR a device, the dom0 kernel
> > > provides a way to do it.
> > > XCP kernels have pciback do_flr that has all the HW specific FLR
> > > functions you are referring to AFAIK, but the pvops kernel, that uses
> > > the standard reset node, does not.
> > >
> > >
> > So it should implement specific FLRs in pciback like XCP/XCI.
> >
>
> Why should we reimplement pci FLR in pciback when the kernel has
> already a way to do it?
> I am not seeing pciback FLR going upstream easily.
> Besides if some devices need specific FLRs, shouldn't the generic kernel
> FLR function know about it?
Yes, absolutely, the correct way to fix this is to add the necessary
fixes/quirks to the upstream FLR infrastructure so that everybody
benefits, not to add stuff to pciback where a) only Xen benefits and b)
we have to maintain it forever because it cannot be upstreamed because
the correct fix is to fix it in the upstream LFR infrastructure ;-).
Ian.
next prev parent reply other threads:[~2010-08-31 10:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 5:51 xl fails to work with some command Zhang, Yang Z
2010-08-23 7:16 ` Zhang, Yang Z
2010-08-23 10:12 ` Stefano Stabellini
2010-08-23 13:32 ` Zhang, Yang Z
2010-08-24 13:21 ` Gianni Tedesco
2010-08-25 1:21 ` Zhang, Yang Z
2010-08-25 2:31 ` Weidong Han
2010-08-25 15:50 ` Stefano Stabellini
2010-08-26 6:10 ` Weidong Han
2010-08-26 12:17 ` Stefano Stabellini
2010-08-26 13:50 ` Konrad Rzeszutek Wilk
2010-08-26 15:47 ` Stefano Stabellini
2010-08-27 0:30 ` Weidong Han
2010-08-27 10:53 ` Stefano Stabellini
2010-08-31 7:07 ` Weidong Han
2010-08-31 9:40 ` Stefano Stabellini
2010-08-31 10:07 ` Ian Campbell [this message]
2010-08-31 13:04 ` Weidong Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283249247.12544.9361.camel@zakaz.uk.xensource.com \
--to=ian.campbell@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=weidong.han@intel.com \
--cc=xen-devel@lists.xensource.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.