From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751802Ab0IGFBZ (ORCPT ); Tue, 7 Sep 2010 01:01:25 -0400 Received: from mail.perches.com ([173.55.12.10]:1493 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061Ab0IGFBT (ORCPT ); Tue, 7 Sep 2010 01:01:19 -0400 Subject: [PATCH net-next] include/net/raw.h: Convert raw_seq_private macro to inline From: Joe Perches To: David Miller Cc: trivial@kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20100906.184749.214227378.davem@davemloft.net> References: <20100906.183036.68150190.davem@davemloft.net> <20100906.184749.214227378.davem@davemloft.net> Content-Type: text/plain; charset="UTF-8" Date: Mon, 06 Sep 2010 22:01:17 -0700 Message-ID: <1283835677.23280.108.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2010-09-06 at 18:47 -0700, David Miller wrote: > raw_seq_private() expands to something which dereferences the pointer, > which you've now made void, which is illegal and breaks the build. > Reverted. Apologies, I had this in my tree which I didn't send because it wasn't a private_data cast removal. Signed-off-by: Joe Perches --- include/net/raw.h | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/net/raw.h b/include/net/raw.h index 43c5750..c621200 100644 --- a/include/net/raw.h +++ b/include/net/raw.h @@ -45,7 +45,10 @@ struct raw_iter_state { struct raw_hashinfo *h; }; -#define raw_seq_private(seq) ((struct raw_iter_state *)(seq)->private) +inline struct raw_iter_state *raw_seq_private(struct seq_file *seq) +{ + return seq->private; +} void *raw_seq_start(struct seq_file *seq, loff_t *pos); void *raw_seq_next(struct seq_file *seq, void *v, loff_t *pos); void raw_seq_stop(struct seq_file *seq, void *v);