From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56357 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtL2W-0004sL-7W for qemu-devel@nongnu.org; Wed, 08 Sep 2010 09:50:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OtKie-0005aV-BN for qemu-devel@nongnu.org; Wed, 08 Sep 2010 09:29:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14016) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OtKie-0005aQ-5E for qemu-devel@nongnu.org; Wed, 08 Sep 2010 09:29:44 -0400 From: Kevin Wolf Date: Wed, 8 Sep 2010 15:29:31 +0200 Message-Id: <1283952582-17498-15-git-send-email-kwolf@redhat.com> In-Reply-To: <1283952582-17498-1-git-send-email-kwolf@redhat.com> References: <1283952582-17498-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 14/25] scsi-disk: fix the block descriptor returned by the MODE SENSE command List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Bernhard Kohl The block descriptor contains the number of blocks, not the highest LBA. Real hard disks return 0 if the number of blocks exceed the maximum 0xFFFFFF. SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.3.3 "The number of blocks field specifies the number of logical blocks on the medium to which the density code and block length fields apply. A value of zero indicates that all of the remaining logical blocks of the logical unit shall have the medium characteristics specified." Signed-off-by: Bernhard Kohl Signed-off-by: Kevin Wolf --- hw/scsi-disk.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 1287cab..e085d5b 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -662,9 +662,8 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req, uint8_t *outbuf) outbuf[7] = 8; /* Block descriptor length */ } nb_sectors /= s->cluster_size; - nb_sectors--; if (nb_sectors > 0xffffff) - nb_sectors = 0xffffff; + nb_sectors = 0; p[0] = 0; /* media density code */ p[1] = (nb_sectors >> 16) & 0xff; p[2] = (nb_sectors >> 8) & 0xff; -- 1.7.2.2