[PATCH] Revert "drm/i915: Allow LVDS on pipe A on gen4+"

[PATCH] Revert "drm/i915: Allow LVDS on pipe A on gen4+"

[Chris Wilson]

This reverts commit 0f3ee801b332d6ff22285386675fe5aaedf035c3.

Enabling LVDS on pipe A was causing excessive wakeups on otherwise idle
system due to i915 interrupts. So restrict the LVDS to pipe B once more,
whilst the issue is properly diagnosed.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=16307
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Adam Jackson <ajax@redhat.com>
Cc: stable@kernel.org
---
 drivers/gpu/drm/i915/intel_lvds.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index b819c10..4fbb016 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -875,8 +875,6 @@ void intel_lvds_init(struct drm_device *dev)
 
 	intel_encoder->clone_mask = (1 << INTEL_LVDS_CLONE_BIT);
 	intel_encoder->crtc_mask = (1 << 1);
-	if (IS_I965G(dev))
-		intel_encoder->crtc_mask |= (1 << 0);
 	drm_encoder_helper_add(encoder, &intel_lvds_helper_funcs);
 	drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
 	connector->display_info.subpixel_order = SubPixelHorizontalRGB;
-- 
1.7.1

Re: [PATCH] Revert "drm/i915: Allow LVDS on pipe A on gen4+"

[Adam Jackson]

[-- Attachment #1.1: Type: text/plain, Size: 532 bytes --]

On Tue, 2010-09-07 at 23:45 +0100, Chris Wilson wrote:
> This reverts commit 0f3ee801b332d6ff22285386675fe5aaedf035c3.
> 
> Enabling LVDS on pipe A was causing excessive wakeups on otherwise idle
> system due to i915 interrupts. So restrict the LVDS to pipe B once more,
> whilst the issue is properly diagnosed.

I've seen more than one machine where LVDS comes up on pipe A from BIOS,
so this will necessitate a DPMS cycle when loading the KMS driver.

Oh well.

Reviewed-by: Adam Jackson <ajax@redhat.com>

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx