All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ipheth: remove incorrect devtype to WWAN
@ 2010-09-08 17:50 Dan Williams
       [not found] ` <1283968247.2839.14.camel-wKZy7rqYPVb5EHUCmHmTqw@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2010-09-08 17:50 UTC (permalink / raw)
  To: netdev-u79uwXL29TY76Z2rM5mHXA
  Cc: Diego Giagio, linux-usb-u79uwXL29TY76Z2rM5mHXA

The 'wwan' devtype is meant for devices that require preconfiguration
and *every* time setup before the ethernet interface can be used, like
cellular modems which require a series of setup commands on serial ports
or other mechanisms before the ethernet interface will handle packets.

As ipheth only requires one-per-hotplug pairing setup with no
preconfiguration (like APN, phone #, etc) and the network interface is
usable at any time after that initial setup, remove the incorrect
devtype wwan.

Signed-off-by: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---

diff --git a/drivers/net/usb/ipheth.c b/drivers/net/usb/ipheth.c
index 08e7b6a..3388569 100644
--- a/drivers/net/usb/ipheth.c
+++ b/drivers/net/usb/ipheth.c
@@ -424,10 +424,6 @@ static const struct net_device_ops ipheth_netdev_ops = {
 	.ndo_get_stats = &ipheth_stats,
 };
 
-static struct device_type ipheth_type = {
-	.name	= "wwan",
-};

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ipheth: remove incorrect devtype to WWAN
       [not found] ` <1283968247.2839.14.camel-wKZy7rqYPVb5EHUCmHmTqw@public.gmane.org>
@ 2010-09-10  4:42   ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-09-10  4:42 UTC (permalink / raw)
  To: dcbw-H+wXaHxf7aLQT0dZR+AlfA
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, diego-KR0zwsgql1HQT0dZR+AlfA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

From: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Date: Wed, 08 Sep 2010 12:50:47 -0500

> The 'wwan' devtype is meant for devices that require preconfiguration
> and *every* time setup before the ethernet interface can be used, like
> cellular modems which require a series of setup commands on serial ports
> or other mechanisms before the ethernet interface will handle packets.
> 
> As ipheth only requires one-per-hotplug pairing setup with no
> preconfiguration (like APN, phone #, etc) and the network interface is
> usable at any time after that initial setup, remove the incorrect
> devtype wwan.
> 
> Signed-off-by: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Applied, thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-10  4:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-08 17:50 [PATCH] ipheth: remove incorrect devtype to WWAN Dan Williams
     [not found] ` <1283968247.2839.14.camel-wKZy7rqYPVb5EHUCmHmTqw@public.gmane.org>
2010-09-10  4:42   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.