From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36799 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OuQhU-0002Oy-9t for qemu-devel@nongnu.org; Sat, 11 Sep 2010 10:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OuQhR-0004yB-PW for qemu-devel@nongnu.org; Sat, 11 Sep 2010 10:05:04 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:55882) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OuQhR-0004xr-NE for qemu-devel@nongnu.org; Sat, 11 Sep 2010 10:05:01 -0400 Received: from d01relay01.pok.ibm.com (d01relay01.pok.ibm.com [9.56.227.233]) by e6.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o8BE4vsM031635 for ; Sat, 11 Sep 2010 10:04:57 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay01.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o8BE51Yj335938 for ; Sat, 11 Sep 2010 10:05:01 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o8BE51Jm017063 for ; Sat, 11 Sep 2010 10:05:01 -0400 From: Anthony Liguori Date: Sat, 11 Sep 2010 09:04:55 -0500 Message-Id: <1284213896-12705-3-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1284213896-12705-1-git-send-email-aliguori@us.ibm.com> References: <1284213896-12705-1-git-send-email-aliguori@us.ibm.com> Subject: [Qemu-devel] [PATCH 2/3] block-nbd: fix use of protocols in backing files and nbd probing List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi , Juan Quintela The use of protocols in backing_files is currently broken because of some checks for adjusting relative pathnames. Additionally, there's a spurious read when using an nbd protocol that can be quite destructive when using copy-on-read. Potentially, this can lead to probing an image file over top of NBD but this is completely wrong as NBD devices are not growable. Signed-off-by: Anthony Liguori --- NB: this is absolutely not ideal. A more elegant suggestion would be appreciated. I don't think NBD cleanly fits the model of a protocol as it stands today. diff --git a/block.c b/block.c index cd2ee31..a32d5dd 100644 --- a/block.c +++ b/block.c @@ -344,6 +344,12 @@ static int find_image_format(const char *filename, BlockDriver **pdrv) return ret; } + if (strcmp(bs->drv->protocol_name, "nbd") == 0) { + drv = bs->drv; + bdrv_delete(bs); + goto out; + } + /* Return the raw BlockDriver * to scsi-generic devices or empty drives */ if (bs->sg || !bdrv_is_inserted(bs)) { bdrv_delete(bs); @@ -373,6 +379,7 @@ static int find_image_format(const char *filename, BlockDriver **pdrv) } } } +out: if (!drv) { ret = -ENOENT; } @@ -603,10 +610,16 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, BlockDriver *back_drv = NULL; bs->backing_hd = bdrv_new(""); - path_combine(backing_filename, sizeof(backing_filename), - filename, bs->backing_file); - if (bs->backing_format[0] != '\0') - back_drv = bdrv_find_format(bs->backing_format); + back_drv = bdrv_find_protocol(bs->backing_file); + if (!back_drv) { + path_combine(backing_filename, sizeof(backing_filename), + filename, bs->backing_file); + if (bs->backing_format[0] != '\0') + back_drv = bdrv_find_format(bs->backing_format); + } else { + pstrcpy(backing_filename, sizeof(backing_filename), + bs->backing_file); + } /* backing files always opened read-only */ back_flags = -- 1.7.0.4