All of lore.kernel.org
 help / color / mirror / Atom feed
* [regression] *ERROR* timed out waiting for FORCE_DETECT in 36rc3 on i915
@ 2010-09-08 13:53 Andi Kleen
  2010-09-12 18:40 ` Maciej Rutecki
  2010-09-12 19:07   ` Chris Wilson
  0 siblings, 2 replies; 4+ messages in thread
From: Andi Kleen @ 2010-09-08 13:53 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx, Dave Airlie, linux-kernel


One of my test box with Intel graphics spews out a lot of 

[drm:intel_crt_detect_hotplug] *ERROR* timed out waiting for FORCE_DETECT to go off

messages after boot now. This didn't show in 2.6.35, so it seems
like a regression. The system just runs in VGA text mode
(but with KMS) without X.

-Andi

Hardware information

[drm] Initialized drm 1.1.0 20060810
[drm] radeon defaulting to userspace modesetting.
i915 0000:00:02.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
i915 0000:00:02.0: setting latency timer to 64
  alloc irq_desc for 42 on node -1
  alloc kstat_irqs on node -1
i915 0000:00:02.0: irq 42 for MSI/MSI-X
[drm] set up 7M of stolen space
vgaarb: device changed decodes: PCI:0000:00:02.0,olddecodes=io+mem,decodes=io+mem:owns=io+mem
[drm] initialized overlay support
Console: switching to colour frame buffer device 128x48
fb0: inteldrmfb frame buffer device
drm: registered panic notifier
No ACPI video bus found
[drm] Initialized i915 1.6.0 20080730 for 0000:00:02.0 on minor 0

00:02.0 VGA compatible controller: Intel Corporation: Unknown device 29c2 (rev 02)

-- 
ak@linux.intel.com -- Speaking for myself only.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [regression] *ERROR* timed out waiting for FORCE_DETECT in 36rc3 on i915
  2010-09-08 13:53 [regression] *ERROR* timed out waiting for FORCE_DETECT in 36rc3 on i915 Andi Kleen
@ 2010-09-12 18:40 ` Maciej Rutecki
  2010-09-12 19:07   ` Chris Wilson
  1 sibling, 0 replies; 4+ messages in thread
From: Maciej Rutecki @ 2010-09-12 18:40 UTC (permalink / raw)
  To: Andi Kleen; +Cc: Chris Wilson, intel-gfx, Dave Airlie, linux-kernel

On środa, 8 września 2010 o 15:53:16 Andi Kleen wrote:
> One of my test box with Intel graphics spews out a lot of
> 
> [drm:intel_crt_detect_hotplug] *ERROR* timed out waiting for FORCE_DETECT
> to go off

I created a Bugzilla entry at 
https://bugzilla.kernel.org/show_bug.cgi?id=18332
for your bug report, please add your address to the CC list in there, thanks!

-- 
Maciej Rutecki
http://www.maciek.unixy.pl

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] drm/i915/crt: Downgrade warnings for hotplug failures
  2010-09-08 13:53 [regression] *ERROR* timed out waiting for FORCE_DETECT in 36rc3 on i915 Andi Kleen
@ 2010-09-12 19:07   ` Chris Wilson
  2010-09-12 19:07   ` Chris Wilson
  1 sibling, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2010-09-12 19:07 UTC (permalink / raw)
  To: andi; +Cc: linux-kernel, intel-gfx, Chris Wilson

These are not fatal errors, so do not alarm the user by filling the
logs with *** ERROR ***. Especially as we know that g4x CRT detection
is a little sticky.

On the one hand the errors are valid since they are warning us of a
stall -- we poll the register whilst holding the mode lock so not even
the mouse will update. On the other hand, those stalls were already present
yet nobody complained.

Reported-by: Andi Kleen <andi@firstfloor.org>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=18332
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_crt.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index a02a8df..197d4f3 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -188,7 +188,7 @@ static bool intel_ironlake_crt_detect_hotplug(struct drm_connector *connector)
 
 	if (wait_for((I915_READ(PCH_ADPA) & ADPA_CRT_HOTPLUG_FORCE_TRIGGER) == 0,
 		     1000, 1))
-		DRM_ERROR("timed out waiting for FORCE_TRIGGER");
+		DRM_DEBUG_KMS("timed out waiting for FORCE_TRIGGER");
 
 	if (turn_off_dac) {
 		I915_WRITE(PCH_ADPA, temp);
@@ -245,7 +245,7 @@ static bool intel_crt_detect_hotplug(struct drm_connector *connector)
 		if (wait_for((I915_READ(PORT_HOTPLUG_EN) &
 			      CRT_HOTPLUG_FORCE_DETECT) == 0,
 			     1000, 1))
-			DRM_ERROR("timed out waiting for FORCE_DETECT to go off");
+			DRM_DEBUG_KMS("timed out waiting for FORCE_DETECT to go off");
 	}
 
 	stat = I915_READ(PORT_HOTPLUG_STAT);
-- 
1.7.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] drm/i915/crt: Downgrade warnings for hotplug failures
@ 2010-09-12 19:07   ` Chris Wilson
  0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2010-09-12 19:07 UTC (permalink / raw)
  To: andi; +Cc: intel-gfx, linux-kernel

These are not fatal errors, so do not alarm the user by filling the
logs with *** ERROR ***. Especially as we know that g4x CRT detection
is a little sticky.

On the one hand the errors are valid since they are warning us of a
stall -- we poll the register whilst holding the mode lock so not even
the mouse will update. On the other hand, those stalls were already present
yet nobody complained.

Reported-by: Andi Kleen <andi@firstfloor.org>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=18332
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_crt.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index a02a8df..197d4f3 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -188,7 +188,7 @@ static bool intel_ironlake_crt_detect_hotplug(struct drm_connector *connector)
 
 	if (wait_for((I915_READ(PCH_ADPA) & ADPA_CRT_HOTPLUG_FORCE_TRIGGER) == 0,
 		     1000, 1))
-		DRM_ERROR("timed out waiting for FORCE_TRIGGER");
+		DRM_DEBUG_KMS("timed out waiting for FORCE_TRIGGER");
 
 	if (turn_off_dac) {
 		I915_WRITE(PCH_ADPA, temp);
@@ -245,7 +245,7 @@ static bool intel_crt_detect_hotplug(struct drm_connector *connector)
 		if (wait_for((I915_READ(PORT_HOTPLUG_EN) &
 			      CRT_HOTPLUG_FORCE_DETECT) == 0,
 			     1000, 1))
-			DRM_ERROR("timed out waiting for FORCE_DETECT to go off");
+			DRM_DEBUG_KMS("timed out waiting for FORCE_DETECT to go off");
 	}
 
 	stat = I915_READ(PORT_HOTPLUG_STAT);
-- 
1.7.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-09-12 19:04 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-08 13:53 [regression] *ERROR* timed out waiting for FORCE_DETECT in 36rc3 on i915 Andi Kleen
2010-09-12 18:40 ` Maciej Rutecki
2010-09-12 19:07 ` [PATCH] drm/i915/crt: Downgrade warnings for hotplug failures Chris Wilson
2010-09-12 19:07   ` Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.