From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Matthew Wilcox <willy@linux.intel.com>,
Christoph Hellwig <hch@lst.de>,
"J. Bruce Fields" <bfields@fieldses.org>,
Miklos Szeredi <mszeredi@suse.cz>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>, John Kacur <jkacur@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Remove BKL from fs/locks.c
Date: Tue, 14 Sep 2010 17:55:56 -0400 [thread overview]
Message-ID: <1284501356.10782.139.camel@heimdal.trondhjem.org> (raw)
In-Reply-To: <201009142324.16074.arnd@arndb.de>
On Tue, 2010-09-14 at 23:24 +0200, Arnd Bergmann wrote:
> On Tuesday 14 September 2010 22:53:31 Linus Torvalds wrote:
> > Oh well. I guess there's no incremental way to do things sanely. And
> > nobody has patches to fix those users, I guess.
>
> The only critical user is fs/lockd, I can easily handle the rest.
> When I talked to Bruce and Trond during LinuxCon, they told me that
> it should be possible to separate the bits of fs/lockd that lock
> against fs/locks.c and convert the former to use lock_flocks().
The NFSv4 client is quite ready to just switch to using lock_flocks()
now. There is nothing that depends on the magical properties of the BKL.
I do also have someone working on BKL removal for the NLM/lockd client
and am hoping that should be ready in a couple of weeks time.
The timeline for the server is up to Bruce, however.
> That would be enough to actually apply this patch without the
> nasty CONFIG_BKL check and with changes to the few other
> consumers of file locks. My original plan was to have my current
> patch in -next until that happens.
Would it be possible to at least merge a patch that defines
lock_flocks() (even if it just is an alias for lock_kernel()), so that
we can convert those bits of the lock recovery code that need to peek
into the inode->i_flock list ASAP?
Cheers
Trond
next prev parent reply other threads:[~2010-09-14 21:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 20:06 [PATCH] Remove BKL from fs/locks.c Arnd Bergmann
2010-09-14 20:20 ` Linus Torvalds
2010-09-14 20:39 ` Arnd Bergmann
2010-09-14 20:53 ` Linus Torvalds
2010-09-14 21:24 ` Arnd Bergmann
2010-09-14 21:55 ` Trond Myklebust [this message]
2010-09-15 16:30 ` Arnd Bergmann
2010-09-15 17:02 ` Sage Weil
2010-09-15 17:17 ` Arnd Bergmann
2010-09-15 18:22 ` Sage Weil
2010-09-15 20:42 ` J. Bruce Fields
2010-09-16 8:28 ` Arnd Bergmann
2010-09-16 14:10 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284501356.10782.139.camel@heimdal.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bfields@fieldses.org \
--cc=fweisbec@gmail.com \
--cc=hch@lst.de \
--cc=jkacur@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mszeredi@suse.cz \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.