All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Tejun Heo <tj@kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [REGRESSION] cdrom drive doesn't detect removal
Date: Thu, 16 Sep 2010 00:20:07 +0200	[thread overview]
Message-ID: <1284589207.4672.3.camel@maxim-laptop> (raw)
In-Reply-To: <AANLkTinGDUxsgaGey7EnYOu3kKP-YRE00gL33hiKvAWj@mail.gmail.com>

On Wed, 2010-09-15 at 15:44 +0200, Kay Sievers wrote: 
> On Wed, Sep 15, 2010 at 15:27, Henrique de Moraes Holschuh
> <hmh@hmh.eng.br> wrote:
> > On Wed, 15 Sep 2010, Kay Sievers wrote:
> >> It's only the polling that should be able to trigger these events for
> >> the device. the device itself can't report any changes to the host,
> >> unless you have a SATA drive which can send AN (async notification)
> >> events. But we disabled the AN support recently, because it was
> >> running in loops on some boxes.
> >
> > Is it so widespread or extremely difficult to detect, that it justifies
> > breaking AN for all users?
> 
> Yes. It's not properly implemented, and many drives just always send
> an event on access, regardless if the media is changed or not. To work
> properly, it will need in-kernel media presence polling, which is
> being worked on. The current AN events, the stuff the drives send, and
> the way it is handled in the kernel, is just not usable.
> 
> > Anyway, if userspace thinks AN is available, it won't pool or touch
> > /dev/sr*, which would explain the problem (but one still would have to find
> > the root cause: why userspace thinks it doesn't need to pool?).
> 
> There is no userspace checking for AN support right now. It wouldn't
> work anyway. And the only thing that makes sense is to move the
> polling in the kernel regardless of AN support or not, and make
> userspace check for that and skip polling when the kernel takes care.

So it makes the sense.
It turns out that hal is still running on ubuntu systems, and yes, it
still polls the drives, and yes I disabled that feature....
So restoring that polling feature indeed fixes that problem for now.
Yet, why without that commit detection did work?

Best regards,
Maxim Levitsky


  reply	other threads:[~2010-09-15 22:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-12  9:49 [REGRESSION] cdrom drive doesn't detect removal Maxim Levitsky
2010-09-14  1:27 ` Maxim Levitsky
2010-09-14  7:39   ` Tejun Heo
2010-09-14  8:07     ` Kay Sievers
2010-09-14 23:38       ` Maxim Levitsky
2010-09-14 23:49         ` Kay Sievers
2010-09-15  0:37           ` Maxim Levitsky
2010-09-15  1:01             ` Kay Sievers
2010-09-15 13:27               ` Henrique de Moraes Holschuh
2010-09-15 13:44                 ` Kay Sievers
2010-09-15 22:20                   ` Maxim Levitsky [this message]
2010-09-16  6:51                     ` Kay Sievers
2010-09-21 11:42                       ` Maxim Levitsky
2010-09-21 23:09                         ` Maxim Levitsky
2010-09-22  7:38                           ` Tejun Heo
2010-09-22 13:41                             ` Maxim Levitsky
2010-09-22 13:58                               ` Maxim Levitsky
2010-09-23  8:47                                 ` Tejun Heo
2010-09-23  9:21                                   ` Kay Sievers
2010-09-30  6:30                                     ` Florian Mickler
2010-09-30  7:48                                       ` Kay Sievers
2010-09-30 11:38                                         ` Florian Mickler
2010-09-30 14:17                                           ` Maxim Levitsky
2010-09-30 14:49                                             ` Florian Mickler
2010-09-30 19:27                                               ` Kay Sievers
2010-09-30 20:14                                                 ` Florian Mickler
2010-09-30 20:32                                                   ` Kay Sievers
2010-09-30 20:47                                                     ` Florian Mickler
2010-09-30 20:57                                                       ` Kay Sievers
2010-10-01  5:55                                               ` Tejun Heo
2010-10-01  7:54                                                 ` Florian Mickler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284589207.4672.3.camel@maxim-laptop \
    --to=maximlevitsky@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hmh@hmh.eng.br \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.