From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
Subject: Re: Re: [Patch] update cpumask handling for cpu pools
	in libxc and python
Date: Fri, 17 Sep 2010 11:10:57 +0100
Message-ID: <1284718257.16095.3217.camel@zakaz.uk.xensource.com>
References: <4C9301DB.4050009@ts.fujitsu.com>
	<1284714037.16095.3083.camel@zakaz.uk.xensource.com>
	<4C9332EA.3030006@ts.fujitsu.com>
	<1284716674.16095.3180.camel@zakaz.uk.xensource.com>
	<4C933D1B.3040308@ts.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4C933D1B.3040308@ts.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2010-09-17 at 11:04 +0100, Juergen Gross wrote:
> On 09/17/10 11:44, Ian Campbell wrote:
> > On Fri, 2010-09-17 at 10:20 +0100, Juergen Gross wrote:
> >> On 09/17/10 11:00, Ian Campbell wrote:
> >>> local_size has already been rounded up in get_cpumap_size. Do we really
> >>> need to do it again?
> >>
> >> I've made it more clear that this is rounding to uint64.
> >
> > Wouldn't that be "(.. + 63) / 8" then?
> 
> No, local_size is already bytes...

Oh yeah.

I think that helps make my point about the confusion inherent in using
variously bits, bytes and uint64s as you move up the callstack ;-)

> This would suggest changing xc_vcpu_setaffinity() and

Not sure if others will agree but personally I'd be fine with that.

Ian.