All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 01/25] arch/mips: Use static const char arrays
Date: Sat, 18 Sep 2010 16:44:59 -0700	[thread overview]
Message-ID: <1284853499.1778.83.camel@Joe-Laptop> (raw)
In-Reply-To: <20100918225447.GA4739@linux-mips.org>

On Sat, 2010-09-18 at 23:54 +0100, Ralf Baechle wrote:
> On Mon, Sep 13, 2010 at 12:47:39PM -0700, Joe Perches wrote:
> > diff --git a/arch/mips/pnx8550/common/reset.c b/arch/mips/pnx8550/common/reset.c
> > index fadd874..e0ac0b2 100644
> > --- a/arch/mips/pnx8550/common/reset.c
> > +++ b/arch/mips/pnx8550/common/reset.c
> > @@ -27,8 +27,8 @@
> >  
> >  void pnx8550_machine_restart(char *command)
> >  {
> > -	char head[] = "************* Machine restart *************";
> > -	char foot[] = "*******************************************";
> > +	static const char head[] = "************* Machine restart *************";
> > +	static const char foot[] = "*******************************************";
> >  
> >  	printk("\n\n");
> >  	printk("%s\n", head);
> NAK.
> The printks should have been taken out and shot.  And while at it line
> use the space on the other side of the wall for pnx8550_machine_power_off.

Fix them up as you see fit Ralf.

I don't have the hardware and was simply moving stuff
that should be const into const ro sections.

There are a lot of defects in that file, for instance
the printks don't use KERN_<level>.

cheers, Joe


  reply	other threads:[~2010-09-18 23:45 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 19:47 [PATCH 00/25] treewide-next: Use static const char arrays Joe Perches
2010-09-13 19:47 ` Joe Perches
2010-09-13 19:47 ` Joe Perches
2010-09-13 19:47 ` Joe Perches
2010-09-13 19:47 ` [PATCH 01/25] arch/mips: " Joe Perches
2010-09-18 22:54   ` Ralf Baechle
2010-09-18 23:44     ` Joe Perches [this message]
2010-09-13 19:47 ` [PATCH 02/25] arch/powerpc: " Joe Perches
2010-09-13 19:47   ` Joe Perches
2010-09-14  2:02   ` Stephen Rothwell
2010-09-14  2:02     ` Stephen Rothwell
2010-09-14  2:04   ` Stephen Rothwell
2010-09-14  2:04     ` Stephen Rothwell
2010-09-13 19:47 ` [PATCH 03/25] drivers/acpi: " Joe Perches
2010-09-13 19:47 ` [PATCH 04/25] drivers/char: " Joe Perches
2010-09-14  2:06   ` Stephen Rothwell
2010-09-14  2:06     ` Stephen Rothwell
2010-09-13 19:47 ` [PATCH 05/25] drivers/i2c: " Joe Perches
2010-09-13 19:47   ` Joe Perches
2010-09-13 19:47   ` Joe Perches
2010-09-13 19:56   ` Russell King - ARM Linux
2010-09-13 19:56     ` Russell King - ARM Linux
2010-09-13 19:56     ` Russell King - ARM Linux
2010-09-13 20:08   ` Jonathan Cameron
2010-09-13 20:08     ` Jonathan Cameron
2010-09-13 20:08     ` Jonathan Cameron
2010-09-13 20:16     ` Joe Perches
2010-09-13 20:16       ` Joe Perches
2010-09-13 20:16       ` Joe Perches
2010-09-14  7:36     ` Lothar Waßmann
2010-09-14  7:36       ` Lothar Waßmann
2010-09-14  7:36       ` Lothar Waßmann
2010-09-14 12:57       ` Jonathan Cameron
2010-09-14 12:57         ` Jonathan Cameron
2010-09-14 12:57         ` Jonathan Cameron
2010-09-14 19:48         ` Russell King - ARM Linux
2010-09-14 19:48           ` Russell King - ARM Linux
2010-09-14 19:48           ` Russell King - ARM Linux
2010-09-14 23:23   ` Ben Dooks
2010-09-14 23:23     ` Ben Dooks
2010-09-14 23:23     ` Ben Dooks
2010-09-13 19:47 ` [PATCH 06/25] drivers/isdn: " Joe Perches
2010-09-13 19:47 ` [PATCH 07/25] drivers/media: " Joe Perches
2010-09-13 21:50   ` Mauro Carvalho Chehab
2010-09-13 22:07     ` [PATCH 07/25] drivers/media/video/zoran: Don't use initialized char array Joe Perches
2010-09-13 19:47 ` [PATCH 08/25] drivers/net/atl1c: Use static const char arrays Joe Perches
2010-09-13 19:47 ` [PATCH 09/25] drivers/net/atl1e: " Joe Perches
2010-09-13 19:47 ` [PATCH 10/25] drivers/net/(intel): " Joe Perches
2010-09-13 19:47   ` Joe Perches
2010-09-13 19:47 ` [PATCH 11/25] drivers/net/netxen: " Joe Perches
2010-09-13 19:47 ` [PATCH 12/25] drivers/net/qlcnic: " Joe Perches
2010-09-13 19:47 ` [PATCH 13/25] drivers/net/spider_net.c: " Joe Perches
2010-09-13 19:47 ` [PATCH 14/25] drivers/net/vnxnet3: " Joe Perches
2010-09-13 19:50   ` [Pv-drivers] " Bhavesh Davda
2010-09-13 20:07   ` Shreyas Bhatewara
2010-09-13 19:47 ` [PATCH 15/25] drivers/net/wireless/ipw2x00: " Joe Perches
2010-09-14 18:41   ` John W. Linville
2010-09-13 19:47 ` [PATCH 16/25] drivers/s390/char: " Joe Perches
2010-09-13 19:47 ` [PATCH 17/25] drivers/scsi: " Joe Perches
2010-09-13 19:47 ` [PATCH 18/25] drivers/serial/suncore.c: " Joe Perches
2010-09-13 19:47   ` Joe Perches
2010-09-13 20:36   ` Alan Cox
2010-09-13 20:36     ` [PATCH 18/25] drivers/serial/suncore.c: Use static const char Alan Cox
2010-09-13 20:22     ` [PATCH 18/25] drivers/serial/suncore.c: Use static const char arrays Joe Perches
2010-09-13 20:22       ` [PATCH 18/25] drivers/serial/suncore.c: Use static const char Joe Perches
2010-09-13 21:11       ` [PATCH 18/25] drivers/serial/suncore.c: Use static const char arrays Nick Bowler
2010-09-13 21:11         ` [PATCH 18/25] drivers/serial/suncore.c: Use static const char Nick Bowler
2010-09-13 21:17         ` [PATCH 18/25] drivers/serial/suncore.c: Use static const char arrays Joe Perches
2010-09-13 21:17           ` [PATCH 18/25] drivers/serial/suncore.c: Use static const char Joe Perches
2010-09-13 19:47 ` [PATCH 19/25] drivers/staging: Use static const char arrays Joe Perches
2010-09-13 19:47 ` [PATCH 20/25] drivers/usb: " Joe Perches
2010-09-13 20:38   ` Greg KH
2010-09-13 19:47 ` [PATCH 21/25] drivers/video: " Joe Perches
2010-09-13 19:47   ` Joe Perches
2010-09-15 19:02   ` James Simmons
2010-09-15 19:02     ` James Simmons
2010-09-13 19:48 ` [PATCH 22/25] net/dsa: " Joe Perches
2010-09-13 19:48 ` [PATCH 23/25] net/sunrpc: " Joe Perches
2010-09-13 19:48 ` [PATCH 24/25] sound: " Joe Perches
2010-09-13 20:30   ` Takashi Iwai
2010-09-13 20:30     ` Takashi Iwai
2010-09-13 20:47     ` Joe Perches
2010-09-13 21:33       ` Takashi Iwai
2010-09-13 21:33         ` Takashi Iwai
2010-09-13 19:48 ` [PATCH 25/25] tools/perf/util: " Joe Perches
2010-09-14  9:14 ` (unknown) David Howells
2010-09-14  9:14   ` (no subject) David Howells
2010-09-14  9:14   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284853499.1778.83.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.