From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [PATCH 2/8] net: dwc_eth_qos: Fix the software reset
Date: Thu, 30 Apr 2020 16:25:44 -0600 [thread overview]
Message-ID: <12848ce1-c637-b44e-557d-384cf1ac4d30@wwwdotorg.org> (raw)
In-Reply-To: <20200430103656.29728-3-david.wu@rock-chips.com>
On 4/30/20 4:36 AM, David Wu wrote:
> When using rgmii Gigabit mode, the wait_for_bit_le32()
> reset method resulting in RX can not receive data, after
> this patch, works well.
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> + limit = eqos->config->swr_wait / 10;
> + while (limit--) {
> + if (!(readl(&eqos->dma_regs->mode) & EQOS_DMA_MODE_SWR))
> + break;
> + mdelay(10000);
> + }
mdelay()'s parameter is in milliseconds judging by its implementation in
include/linux/delay.h. So, this delays 10 seconds in each loop
iteration. That can't possibly be right.
next prev parent reply other threads:[~2020-04-30 22:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 10:36 [PATCH 0/8] Add dwc_eth_qos support for rockchip David Wu
2020-04-30 10:36 ` [PATCH 1/8] net: dwc_eth_qos: Use dev_ functions calls to get FDT data David Wu
2020-04-30 10:36 ` [PATCH 2/8] net: dwc_eth_qos: Fix the software reset David Wu
2020-04-30 15:28 ` Patrice CHOTARD
2020-04-30 22:25 ` Stephen Warren [this message]
2020-04-30 10:36 ` [PATCH 3/8] net: dwc_eth_qos: Add option "snps, reset-gpio" phy-rst gpio for stm32 David Wu
2020-04-30 15:47 ` [PATCH 3/8] net: dwc_eth_qos: Add option "snps,reset-gpio" " Patrice CHOTARD
2020-05-09 2:59 ` David Wu
2020-04-30 22:36 ` [PATCH 3/8] net: dwc_eth_qos: Add option "snps, reset-gpio" " Stephen Warren
2020-04-30 22:42 ` Stephen Warren
2020-05-09 2:41 ` David Wu
2020-05-09 3:32 ` David Wu
2020-04-30 10:36 ` [PATCH 4/8] net: dwc_eth_qos: Move interface() to eqos_ops struct David Wu
2020-04-30 22:39 ` Stephen Warren
2020-05-09 3:22 ` David Wu
2020-04-30 10:43 ` [PATCH 5/8] net: dwc_eth_qos: Make clk_rx and clk_tx optional David Wu
2020-04-30 14:00 ` Patrice CHOTARD
2020-05-09 6:31 ` David Wu
2020-04-30 22:45 ` Stephen Warren
2020-05-09 6:33 ` David Wu
2020-04-30 10:44 ` [PATCH 6/8] net: dwc_eth_qos: Split eqos_start() to get link speed David Wu
2020-04-30 15:33 ` Patrice CHOTARD
2020-05-09 6:42 ` David Wu
2020-05-11 12:48 ` Patrice CHOTARD
2020-05-12 1:56 ` David Wu
2020-04-30 10:45 ` [PATCH 7/8] net: dwc_eth_qos: Export common struct and interface at head file David Wu
2020-04-30 12:06 ` Patrice CHOTARD
2020-04-30 22:47 ` Stephen Warren
2020-04-30 10:45 ` [PATCH 8/8] net: gmac_rockchip: Add dwc_eth_qos support David Wu
2020-04-30 22:52 ` Stephen Warren
2020-05-09 6:56 ` David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12848ce1-c637-b44e-557d-384cf1ac4d30@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.