All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
To: Ed Tomlinson <edt@aei.ca>
Cc: Michal Marek <mmarek@suse.cz>,
	linux-kbuild@vger.kernel.org,
	Roman Zippel <zippel@linux-m68k.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
Subject: [PATCH 2/2] Fix QT4 moc, cflags libs detection on dual QT3/Qt4 systems
Date: Tue, 21 Sep 2010 19:31:31 +0200	[thread overview]
Message-ID: <1285090291-11247-2-git-send-email-alexander.stein@informatik.tu-chemnitz.de> (raw)
In-Reply-To: <201009181022.31547.edt@aei.ca>

On system with QT3 and QT4 qmake in PATH may be from QT3. So we use
pkg-config for proper QT4 detection.
By reqesting cflags and libs for either QtCore, QtGui and QtSupport include
dirs and libs get listed several times, but so we won't mis anything

CC: Michal Marek <mmarek@suse.cz>
Signed-off-by: Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
---
 scripts/kconfig/Makefile |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index cb02b1e..321aa67 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -274,12 +274,10 @@ $(obj)/.tmp_qtcheck:
 	      moc="/usr/bin/moc"; \
 	    fi; \
 	else \
-	  headerpath="\$$(shell qmake -query QT_INSTALL_HEADERS)"; \
-	  libpath="\$$(shell qmake -query QT_INSTALL_LIBS)"; \
-	  binpath="\$$(shell qmake -query QT_INSTALL_BINS)"; \
-	  cflags="-I$$headerpath -I$$headerpath/QtCore -I$$headerpath/QtGui -I$$headerpath/Qt3Support -DQT3_SUPPORT"; \
-	  libs="-L$$libpath -Wl,-rpath,$$libpath -lQtCore -lQtGui -lQt3Support"; \
-	  moc="$$binpath/moc"; \
+	  cflags="\$$(shell pkg-config QtCore --cflags) \$$(shell pkg-config QtGui --cflags) \$$(shell pkg-config Qt3Support --cflags)"; \
+	  libs="\$$(shell pkg-config QtCore --libs) \$$(shell pkg-config QtGui --libs) \$$(shell pkg-config Qt3Support --libs)"; \
+	  binpath="\$$(shell pkg-config QtCore --variable=prefix)"; \
+	  moc="$$binpath/bin/moc"; \
 	fi; \
 	echo "KC_QT_CFLAGS=$$cflags" > $@; \
 	echo "KC_QT_LIBS=$$libs" >> $@; \
-- 
1.7.3


  parent reply	other threads:[~2010-09-21 17:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-06 17:51 [PATCH] kconfig qconf: port to QT4 Alexander Stein
2010-06-07 12:45 ` Michal Marek
2010-06-07 17:12   ` Alexander Stein
2010-06-07 18:01     ` Gene Heskett
2010-06-07 21:29     ` Michal Marek
2010-07-13 19:26       ` [PATCH v2] " Alexander Stein
2010-07-26 12:44         ` Michal Marek
2010-07-26 12:47           ` Michal Marek
2010-07-26 12:47             ` Michal Marek
2010-07-30 11:15           ` [PATCHi v3] " Alexander Stein
2010-08-01 14:32             ` Ed Tomlinson
2010-08-01 19:28               ` [PATCH] " Alexander Stein
2010-08-02 12:01                 ` Ed Tomlinson
2010-09-18 14:22                   ` Ed Tomlinson
2010-09-20 12:03                     ` Michal Marek
2010-09-21 17:31                     ` [PATCH 1/2] " Alexander Stein
2010-09-21 17:31                     ` Alexander Stein [this message]
2010-08-02 21:29             ` [PATCHi v3] " Michal Marek
2010-08-31 15:34               ` [PATCH v4] " Alexander Stein
2010-09-01 14:57                 ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285090291-11247-2-git-send-email-alexander.stein@informatik.tu-chemnitz.de \
    --to=alexander.stein@informatik.tu-chemnitz.de \
    --cc=edt@aei.ca \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.