From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: [PATCH 2/3] Set cpuid definition to 0 before initializing it Date: Mon, 27 Sep 2010 15:16:16 +0200 Message-ID: <1285593377-1754-3-git-send-email-joerg.roedel@amd.com> References: <1285593377-1754-1-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Joerg Roedel , Alexander Graf , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Avi Kivity , Marcelo Tosatti Return-path: In-Reply-To: <1285593377-1754-1-git-send-email-joerg.roedel@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org This patch cleans the (stack-allocated) cpuid definition to 0 before actually initializing it. Signed-off-by: Joerg Roedel --- target-i386/cpuid.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c index 04ba8d5..3fcf78f 100644 --- a/target-i386/cpuid.c +++ b/target-i386/cpuid.c @@ -788,6 +788,8 @@ int cpu_x86_register (CPUX86State *env, const char *cpu_model) { x86_def_t def1, *def = &def1; + memset(def, 0, sizeof(*def)); + if (cpu_x86_find_by_name(def, cpu_model) < 0) return -1; if (def->vendor1) { -- 1.7.0.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51942 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0DZB-00040S-6q for qemu-devel@nongnu.org; Mon, 27 Sep 2010 09:16:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0DZ7-0006Zz-2z for qemu-devel@nongnu.org; Mon, 27 Sep 2010 09:16:25 -0400 Received: from tx2ehsobe002.messaging.microsoft.com ([65.55.88.12]:11960 helo=TX2EHSOBE004.bigfish.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0DZ6-0006Zg-Vv for qemu-devel@nongnu.org; Mon, 27 Sep 2010 09:16:21 -0400 From: Joerg Roedel Date: Mon, 27 Sep 2010 15:16:16 +0200 Message-ID: <1285593377-1754-3-git-send-email-joerg.roedel@amd.com> In-Reply-To: <1285593377-1754-1-git-send-email-joerg.roedel@amd.com> References: <1285593377-1754-1-git-send-email-joerg.roedel@amd.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH 2/3] Set cpuid definition to 0 before initializing it List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity , Marcelo Tosatti Cc: Joerg Roedel , Alexander Graf , kvm@vger.kernel.org, qemu-devel@nongnu.org This patch cleans the (stack-allocated) cpuid definition to 0 before actually initializing it. Signed-off-by: Joerg Roedel --- target-i386/cpuid.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c index 04ba8d5..3fcf78f 100644 --- a/target-i386/cpuid.c +++ b/target-i386/cpuid.c @@ -788,6 +788,8 @@ int cpu_x86_register (CPUX86State *env, const char *cpu_model) { x86_def_t def1, *def = &def1; + memset(def, 0, sizeof(*def)); + if (cpu_x86_find_by_name(def, cpu_model) < 0) return -1; if (def->vendor1) { -- 1.7.0.4