All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Florian Mickler <florian@mickler.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Wolfram Sang <w.sang@pengutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: RFC: get_maintainer.pl: append reason for cc to the name by default
Date: Mon, 27 Sep 2010 14:16:45 -0700	[thread overview]
Message-ID: <1285622205.4725.34.camel@Joe-Laptop> (raw)
In-Reply-To: <20100927204756.GC3168@thunk.org>

On Mon, 2010-09-27 at 16:47 -0400, Ted Ts'o wrote:
> On Mon, Sep 27, 2010 at 01:08:17PM -0700, Joe Perches wrote:
> > On Mon, 2010-09-27 at 21:26 +0200, Florian Mickler wrote:
> > > But we should definitely try to tune down the annoying part of
> > > it by making it less random and maybe by adding a tag in the cc field...
> > Less random: sure, whatever's reasonable.
> > I still think that tagging the name portion of an email address
> > is not a good idea, especially without some way of turning it
> > off.  Maybe a mechanism to optionally enable it would be ok.
> Well, at the moment, what is currently shipping in git-head and 2.6.35
> does such an __awful__ job that I think a lot of people would be a lot
> happier if we could get the e-mail messages tagged.

Ridiculous exaggeration.  The script doesn't do an _awful_ job.

It includes what some vocal sorts consider suboptimal additional
cc's in some circumstances.  It has for the last year and a half.

Those cc's generally take _seconds_ for a cc'd party to ignore.

> Maybe the call
> for that would be less if some of queued fixes for get_maintainer.pl
> could get pushed out more quickly, or you made an out-of-tree version
> of get_mainatiner.pl so that fixes could get pushed to the newbies
> more quickly.

I already posted the tree.
http://lkml.org/lkml/2010/9/22/464
http://repo.or.cz/w/linux-2.6/get_maintainer.git

> Wouldn't that be a
> valuable way of notifying people of that fact?   :-)

Not really, and it just makes email message threading uglier.

A lot of these are already known.  I've told you multiple
times that arch/arm pattern coverage is poor.  _No_
arch/arm maintainer has made any effort to better describe
the files as it's a fairly difficult job.  And I'm not the
arch/arm maintainer.

Mark Brown said: http://lkml.org/lkml/2010/9/10/116
----------------------------------------------------
On Fri, Sep 10, 2010 at 03:04:26AM -0700, Joe Perches wrote:

> It'd be great if the ARM/embedded folk would spend
> some effort improving the MAINTAINERS file pattern
> coverage.

Half the problem is that a lot of drivers aren't maintained by the
people who wrote them - for example, they wrote the driver to get a
board working but have no ongoing interest or can only really comment on
the one specific configuration used on their particular hardware.  This
means getting people to add MAINTAINERS entries is a bit more tricky
than it needs to be, even if they could offer useful review on changes.
---------------------------------------------------

So for Mark's case, the current behavior works reasonably well.

Tell me something Ted.  Have you in the last 5 years or
so done any work in the kernel outside of fs or modified
files outside of fs when fs structures weren't changed?

Are you representative of the typical user of a script like
get_maintainer or checkpatch?  Does it matter that much?

If you want it, I have a trivial script that shows the files
in the kernel that do not have an "exact pattern match"
in MAINTAINERS.  You could make the effort to find out
if those files should have pattern entries made.   I did
a lot of that privately and found out that most people
appear not to care.




  reply	other threads:[~2010-09-27 21:16 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10  9:33 [PATCH] get_maintainer.pl: append reason for cc to the name by default florian
2010-09-10  9:42 ` Joe Perches
2010-09-10  9:46   ` Wolfram Sang
2010-09-10  9:53   ` Mark Brown
2010-09-10 10:04     ` Joe Perches
2010-09-10 10:18       ` Mark Brown
2010-09-10 10:47         ` Joe Perches
2010-09-10 11:07           ` Mark Brown
2010-09-11  0:22           ` [PATCH] scripts/get_maintainer.pl: Add --git-blame --rolestats "Authored lines" information Joe Perches
2010-09-11  9:38             ` Florian Mickler
2010-09-11  9:52               ` Joe Perches
2010-09-11 10:02                 ` Florian Mickler
2010-09-11 10:22                   ` Joe Perches
2010-09-11 19:22                   ` [PATCH] Documentation/SubmittingPatches: Add and describe scripts/get_maintainer.pl Joe Perches
2010-09-11 19:34                     ` Florian Mickler
2010-09-11 19:43                     ` [PATCH V2] " Joe Perches
2010-09-12 16:18                       ` Florian Mickler
2010-09-10 11:44         ` [PATCH] get_maintainer.pl: append reason for cc to the name by default Alan Cox
2010-09-10 10:22       ` Florian Mickler
2010-09-10 10:47         ` Joe Perches
2010-09-11 21:22     ` Joe Perches
2010-09-10 10:30   ` Florian Mickler
2010-09-10 11:04     ` Mark Brown
2010-09-10 11:15       ` Florian Mickler
2010-09-10 21:04     ` Andrew Morton
2010-09-10 21:39       ` Florian Mickler
2010-09-10 21:44       ` Joe Perches
2010-09-13  4:01     ` Valdis.Kletnieks
2010-09-13  5:21       ` [PATCH] get_maintainer.pl: Look for .get_maintainer.conf in lk, then $HOME then scripts Joe Perches
2010-09-13  6:13         ` Florian Mickler
2010-09-13 13:21         ` Valdis.Kletnieks
2010-09-10 11:11   ` [PATCH] get_maintainer.pl: append reason for cc to the name by default Florian Mickler
2010-09-10 15:12     ` Joe Perches
2010-09-11  9:34       ` Florian Mickler
2010-09-11  0:13   ` Christoph Hellwig
2010-09-11  0:31     ` Joe Perches
2010-09-11  0:45       ` Christoph Hellwig
2010-09-11  0:56         ` Joe Perches
2010-09-11  9:28         ` Florian Mickler
2010-09-13  7:16           ` Eric W. Biederman
2010-09-13  7:57             ` Joe Perches
2010-09-13  8:54               ` Florian Mickler
2010-09-14 17:19                 ` Eric W. Biederman
2010-09-14 17:46                   ` Florian Mickler
2010-09-15  3:28                     ` Joe Perches
2010-09-15  4:34                       ` Florian Mickler
2010-09-15  4:45                         ` Joe Perches
2010-09-15 12:49                           ` Florian Mickler
2010-09-14 23:15                   ` Joe Perches
2010-09-13  9:01             ` Florian Mickler
2010-09-14 17:24               ` Eric W. Biederman
2010-09-26 18:52 ` RFC: " Joe Perches
2010-09-27 14:57   ` Florian Mickler
2010-09-27 15:44     ` Ted Ts'o
2010-09-27 17:00       ` Florian Mickler
2010-09-27 18:21         ` Ted Ts'o
2010-09-27 19:26           ` Florian Mickler
2010-09-27 20:08             ` Joe Perches
2010-09-27 20:47               ` Ted Ts'o
2010-09-27 21:16                 ` Joe Perches [this message]
2010-09-28  4:22                   ` Ted Ts'o
2010-09-28  4:37                   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285622205.4725.34.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=florian@mickler.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=tytso@mit.edu \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.