From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [PATCH 08/18] KVM test: Add basic file transfer test Date: Wed, 29 Sep 2010 11:08:18 -0300 Message-ID: <1285769298.2794.10.camel@freedom> References: <1285627444-2732-1-git-send-email-lmr@redhat.com> <1285627444-2732-9-git-send-email-lmr@redhat.com> <20100928132425.GF14385@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org, akong@redhat.com, jasowang@redhat.com, psuriset@linux.vnet.ibm.com, mgoldish@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63128 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037Ab0I2OI1 (ORCPT ); Wed, 29 Sep 2010 10:08:27 -0400 In-Reply-To: <20100928132425.GF14385@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2010-09-28 at 15:24 +0200, Michael S. Tsirkin wrote: > On Mon, Sep 27, 2010 at 06:43:54PM -0400, Lucas Meneghel Rodrigues wrote: > > From: Amos Kong > > > > This test is the basic test of transfering file between host and guest. > > Try to transfer a large file from host to guest, and transfer it back > > to host, then compare the files by calculate their md5 hash. > > > > The default file size is 4000M, scp timeout is 1000s. It means if the > > average speed is less than 4M/s, this test will be fail. > > We can extend > > this test by using another disk later, then we can transfer larger > > files without the limit of first disk size. > > > > Changes from v1: > > - Use md5 to verify the integrity of files > > - Try to use autotest API, such as, utils.system() > > > > Signed-off-by: Amos Kong > > Why scp_timeout? Not transfer_timeout? > Is this really only scp file transfer to/from linux guest? > Need to either name it so or generalize. Other things that > need testing are NFS for linux guest, scp from windows, samba > for linux and windows guests. Ok, based on your comments, I've made the test more generic. Now the timeout is transfer_timeout, I created a variant called 'remote', that is supposed to use vm.copy_files_* methods, that are implemented for both windows and linux, and made things easy for people to implement new methods of doing this file transfer (nfs, samba, etc). As a bonus, now the test works on windows too :) For now, there's only file_transfer.remote, that uses scp for linux, and rss transfer for windows. In case you don't know what rss is, is a remote shell server that was created for kvm autotest, since we had a lot of problems in the past getting openssh fully functional and working across all the windows versions. We found out that our own, simple remote shell server was way more effective to perform tests on windows. http://autotest.kernel.org/browser/trunk/client/tests/kvm/deps/rss.cpp I am running tests against some windows guests to make sure I got everything right, will publish the new version of the test when I'm done.