From: Moshe Shemesh <moshe@nvidia.com>
To: David Ahern <dsahern@gmail.com>,
Moshe Shemesh <moshe@mellanox.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@nvidia.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2-net 2/3] devlink: Add pr_out_dev() helper function
Date: Wed, 2 Dec 2020 09:00:37 +0200 [thread overview]
Message-ID: <1285ee42-29ed-c06e-1560-1853dbf02823@nvidia.com> (raw)
In-Reply-To: <f44cc093-2199-7e94-561a-a9450511293a@gmail.com>
On 11/29/2020 11:15 PM, David Ahern wrote:
> On 11/26/20 4:14 AM, Moshe Shemesh wrote:
>> diff --git a/devlink/devlink.c b/devlink/devlink.c
>> index a9ba0072..bd588869 100644
>> --- a/devlink/devlink.c
>> +++ b/devlink/devlink.c
>> @@ -2974,17 +2974,11 @@ static int cmd_dev_param(struct dl *dl)
>> pr_err("Command \"%s\" not found\n", dl_argv(dl));
>> return -ENOENT;
>> }
>> -static int cmd_dev_show_cb(const struct nlmsghdr *nlh, void *data)
>> +
>> +static void pr_out_dev(struct dl *dl, struct nlattr **tb)
> why 'pr_out_dev'? there is no 'dev' argument.
Because it prints command dev show output, the data is in tb argument
and includes bus name, dev name and dev stats.
>> {
>> - struct dl *dl = data;
>> - struct nlattr *tb[DEVLINK_ATTR_MAX + 1] = {};
>> - struct genlmsghdr *genl = mnl_nlmsg_get_payload(nlh);
>> uint8_t reload_failed = 0;
>>
>> - mnl_attr_parse(nlh, sizeof(*genl), attr_cb, tb);
>> - if (!tb[DEVLINK_ATTR_BUS_NAME] || !tb[DEVLINK_ATTR_DEV_NAME])
>> - return MNL_CB_ERROR;
>> -
>> if (tb[DEVLINK_ATTR_RELOAD_FAILED])
>> reload_failed = mnl_attr_get_u8(tb[DEVLINK_ATTR_RELOAD_FAILED]);
>>
next prev parent reply other threads:[~2020-12-02 7:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 11:14 [PATCH iproute2-net 0/3] devlink: Add devlink reload action limit and stats Moshe Shemesh
2020-11-26 11:14 ` [PATCH iproute2-net 1/3] devlink: Add devlink reload action and limit options Moshe Shemesh
2020-11-29 21:12 ` David Ahern
2020-12-02 6:57 ` Moshe Shemesh
2020-11-26 11:14 ` [PATCH iproute2-net 2/3] devlink: Add pr_out_dev() helper function Moshe Shemesh
2020-11-29 21:15 ` David Ahern
2020-12-02 7:00 ` Moshe Shemesh [this message]
2020-11-26 11:14 ` [PATCH iproute2-net 3/3] devlink: Add reload stats to dev show Moshe Shemesh
2020-11-29 21:22 ` David Ahern
2020-12-02 7:01 ` Moshe Shemesh
2020-12-01 11:25 ` [PATCH iproute2-net 0/3] devlink: Add devlink reload action limit and stats Vasundhara Volam
2020-12-02 8:44 ` Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285ee42-29ed-c06e-1560-1853dbf02823@nvidia.com \
--to=moshe@nvidia.com \
--cc=dsahern@gmail.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.