From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.9 v3 3/3] xen/livepatch: Don't crash on encountering STN_UNDEF relocations Date: Fri, 23 Jun 2017 14:32:41 +0100 Message-ID: <12865bf5-d94b-51ad-42d2-1b0f0102010a@arm.com> References: <1498155329-4752-1-git-send-email-andrew.cooper3@citrix.com> <1498155329-4752-4-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1498155329-4752-4-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper , Xen-devel Cc: Ross Lagerwall , Stefano Stabellini , Jan Beulich List-Id: xen-devel@lists.xenproject.org SGkgQW5kcmV3LAoKSSBhbSBhIGJpdCBjb25mdXNlZCwgdGhlIHRpdGxlIHNheXMgIlBBVENIIGZv ci00LjkgdjMgMy8zIi4gSSBoYXZlbid0IApiZWVuIENDZWQgb24gdGhlIGZpcnN0IHR3byBwYXRj aGVzLiBEb2VzIGl0IG1lYW4geW91IGFyZSBvbmx5IGxvb2tpbmcgYXQgCnRoaXMgcGF0Y2ggdG8g YmUgaW4gNC45PwoKQ2hlZXJzLAoKT24gMjIvMDYvMTcgMTk6MTUsIEFuZHJldyBDb29wZXIgd3Jv dGU6Cj4gQSBzeW1uZHggb2YgU1ROX1VOREVGIGlzIHNwZWNpYWwsIGFuZCBtZWFucyBhIHN5bWJv bCB2YWx1ZSBvZiAwLiAgV2hpbGUKPiBsZWdpdGltYXRlIGluIHRoZSBFTEYgc3RhbmRhcmQsIGl0 cyBleGlzdGFuY2UgaW4gYSBsaXZlcGF0Y2ggaXMgcXVlc3Rpb25hYmxlCj4gYXQgYmVzdC4gIFVu dGlsIGEgcGxhdXNpYmxlIHVzZWNhc2UgcHJlc2VudHMgaXRzZWxmLCByZWplY3Qgc3VjaCBhIHJl bG9jYXRpb24KPiB3aXRoIC1FT1BOT1RTVVBQLgo+Cj4gQWRkaXRpb25hbGx5LCBmaXggYW4gb2Zm LWJ5LW9uZSBlcnJvciB3aGlsZSByYW5nZSBjaGVja2luZyBzeW1uZHgsIGFuZCBwZXJmb3JtCj4g YSBzYWZldHkgY2hlY2sgb24gZWxmLT5zeW1bc3ltbmR4XS5zeW0gYmVmb3JlIGRlcmVmZW5jaW5n IGl0LCB0byBhdm9pZAo+IHRyaXBwaW5nIG92ZXIgYSBOVUxMIHBvaW50ZXIgd2hlbiBjYWxjdWxh dGluZyB2YWwuCj4KPiBTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgo+IC0tLQo+IENDOiBLb25yYWQgUnplc3p1dGVrIFdpbGsgPGtvbnJhZC53 aWxrQG9yYWNsZS5jb20+Cj4gQ0M6IFJvc3MgTGFnZXJ3YWxsIDxyb3NzLmxhZ2Vyd2FsbEBjaXRy aXguY29tPgo+IENDOiBKYW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5jb20+Cj4gQ0M6IFN0ZWZh bm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4KPiBDQzogSnVsaWVuIEdyYWxs IDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPgo+IHYzOgo+ICAqIEZpeCBvZmYtYnktb25lIGVycm9y Cj4gdjI6Cj4gICogUmVqZWN0IFNUTl9VTkRFRiB3aXRoIC1FT1BOT1RTVVBQCj4gLS0tCj4gIHhl bi9hcmNoL2FybS9hcm0zMi9saXZlcGF0Y2guYyB8IDE0ICsrKysrKysrKysrKystCj4gIHhlbi9h cmNoL2FybS9hcm02NC9saXZlcGF0Y2guYyB8IDE0ICsrKysrKysrKysrKystCj4gIHhlbi9hcmNo L3g4Ni9saXZlcGF0Y2guYyAgICAgICB8IDE0ICsrKysrKysrKysrKystCj4gIDMgZmlsZXMgY2hh bmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC9hcm0vYXJtMzIvbGl2ZXBhdGNoLmMgYi94ZW4vYXJjaC9hcm0vYXJtMzIvbGl2ZXBh dGNoLmMKPiBpbmRleCBhMzI4MTc5Li40MTM3OGE1IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL2Fy bS9hcm0zMi9saXZlcGF0Y2guYwo+ICsrKyBiL3hlbi9hcmNoL2FybS9hcm0zMi9saXZlcGF0Y2gu Ywo+IEBAIC0yNTQsMTIgKzI1NCwyNCBAQCBpbnQgYXJjaF9saXZlcGF0Y2hfcGVyZm9ybShzdHJ1 Y3QgbGl2ZXBhdGNoX2VsZiAqZWxmLAo+ICAgICAgICAgICAgICBhZGRlbmQgPSBnZXRfYWRkZW5k KHR5cGUsIGRlc3QpOwo+ICAgICAgICAgIH0KPgo+IC0gICAgICAgIGlmICggc3ltbmR4ID4gZWxm LT5uc3ltICkKPiArICAgICAgICBpZiAoIHN5bW5keCA9PSBTVE5fVU5ERUYgKQo+ICsgICAgICAg IHsKPiArICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSLCBMSVZFUEFUQ0ggIiVzOiBFbmNv dW50ZXJlZCBTVE5fVU5ERUZcbiIsCj4gKyAgICAgICAgICAgICAgICAgICAgZWxmLT5uYW1lKTsK PiArICAgICAgICAgICAgcmV0dXJuIC1FT1BOT1RTVVBQOwo+ICsgICAgICAgIH0KPiArICAgICAg ICBlbHNlIGlmICggc3ltbmR4ID49IGVsZi0+bnN5bSApCj4gICAgICAgICAgewo+ICAgICAgICAg ICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IFJlbGF0aXZlIHN5bWJvbCB3 YW50cyBzeW1ib2xAJXUgd2hpY2ggaXMgcGFzdCBlbmQhXG4iLAo+ICAgICAgICAgICAgICAgICAg ICAgIGVsZi0+bmFtZSwgc3ltbmR4KTsKPiAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4g ICAgICAgICAgfQo+ICsgICAgICAgIGVsc2UgaWYgKCAhZWxmLT5zeW1bc3ltbmR4XS5zeW0gKQo+ ICsgICAgICAgIHsKPiArICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSLCBMSVZFUEFUQ0gg IiVzOiBObyByZWxhdGl2ZSBzeW1ib2xAJXVcbiIsCj4gKyAgICAgICAgICAgICAgICAgICAgZWxm LT5uYW1lLCBzeW1uZHgpOwo+ICsgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiArICAgICAg ICB9Cj4KPiAgICAgICAgICB2YWwgPSBlbGYtPnN5bVtzeW1uZHhdLnN5bS0+c3RfdmFsdWU7IC8q IFMgKi8KPgo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQvbGl2ZXBhdGNoLmMgYi94 ZW4vYXJjaC9hcm0vYXJtNjQvbGl2ZXBhdGNoLmMKPiBpbmRleCA2MzkyOWIxLi4yMjQ3YjkyIDEw MDY0NAo+IC0tLSBhL3hlbi9hcmNoL2FybS9hcm02NC9saXZlcGF0Y2guYwo+ICsrKyBiL3hlbi9h cmNoL2FybS9hcm02NC9saXZlcGF0Y2guYwo+IEBAIC0yNTIsMTIgKzI1MiwyNCBAQCBpbnQgYXJj aF9saXZlcGF0Y2hfcGVyZm9ybV9yZWxhKHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYsCj4gICAg ICAgICAgaW50IG92ZiA9IDA7Cj4gICAgICAgICAgdWludDY0X3QgdmFsOwo+Cj4gLSAgICAgICAg aWYgKCBzeW1uZHggPiBlbGYtPm5zeW0gKQo+ICsgICAgICAgIGlmICggc3ltbmR4ID09IFNUTl9V TkRFRiApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJ VkVQQVRDSCAiJXM6IEVuY291bnRlcmVkIFNUTl9VTkRFRlxuIiwKPiArICAgICAgICAgICAgICAg ICAgICBlbGYtPm5hbWUpOwo+ICsgICAgICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7Cj4gKyAg ICAgICAgfQo+ICsgICAgICAgIGVsc2UgaWYgKCBzeW1uZHggPj0gZWxmLT5uc3ltICkKPiAgICAg ICAgICB7Cj4gICAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiwgTElWRVBBVENIICIlczog UmVsYXRpdmUgcmVsb2NhdGlvbiB3YW50cyBzeW1ib2xAJXUgd2hpY2ggaXMgcGFzdCBlbmQhXG4i LAo+ICAgICAgICAgICAgICAgICAgICAgIGVsZi0+bmFtZSwgc3ltbmR4KTsKPiAgICAgICAgICAg ICAgcmV0dXJuIC1FSU5WQUw7Cj4gICAgICAgICAgfQo+ICsgICAgICAgIGVsc2UgaWYgKCAhZWxm LT5zeW1bc3ltbmR4XS5zeW0gKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAgZHByaW50ayhY RU5MT0dfRVJSLCBMSVZFUEFUQ0ggIiVzOiBObyByZWxhdGl2ZSBzeW1ib2xAJXVcbiIsCj4gKyAg ICAgICAgICAgICAgICAgICAgZWxmLT5uYW1lLCBzeW1uZHgpOwo+ICsgICAgICAgICAgICByZXR1 cm4gLUVJTlZBTDsKPiArICAgICAgICB9Cj4KPiAgICAgICAgICB2YWwgPSBlbGYtPnN5bVtzeW1u ZHhdLnN5bS0+c3RfdmFsdWUgKyAgci0+cl9hZGRlbmQ7IC8qIFMrQSAqLwo+Cj4gZGlmZiAtLWdp dCBhL3hlbi9hcmNoL3g4Ni9saXZlcGF0Y2guYyBiL3hlbi9hcmNoL3g4Ni9saXZlcGF0Y2guYwo+ IGluZGV4IDc5MTc2MTAuLjQwNmViOTEgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L2xpdmVw YXRjaC5jCj4gKysrIGIveGVuL2FyY2gveDg2L2xpdmVwYXRjaC5jCj4gQEAgLTE3MCwxMiArMTcw LDI0IEBAIGludCBhcmNoX2xpdmVwYXRjaF9wZXJmb3JtX3JlbGEoc3RydWN0IGxpdmVwYXRjaF9l bGYgKmVsZiwKPiAgICAgICAgICB1aW50OF90ICpkZXN0ID0gYmFzZS0+bG9hZF9hZGRyICsgci0+ cl9vZmZzZXQ7Cj4gICAgICAgICAgdWludDY0X3QgdmFsOwo+Cj4gLSAgICAgICAgaWYgKCBzeW1u ZHggPiBlbGYtPm5zeW0gKQo+ICsgICAgICAgIGlmICggc3ltbmR4ID09IFNUTl9VTkRFRiApCj4g KyAgICAgICAgewo+ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAi JXM6IEVuY291bnRlcmVkIFNUTl9VTkRFRlxuIiwKPiArICAgICAgICAgICAgICAgICAgICBlbGYt Pm5hbWUpOwo+ICsgICAgICAgICAgICByZXR1cm4gLUVPUE5PVFNVUFA7Cj4gKyAgICAgICAgfQo+ ICsgICAgICAgIGVsc2UgaWYgKCBzeW1uZHggPj0gZWxmLT5uc3ltICkKPiAgICAgICAgICB7Cj4g ICAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiwgTElWRVBBVENIICIlczogUmVsYXRpdmUg cmVsb2NhdGlvbiB3YW50cyBzeW1ib2xAJXUgd2hpY2ggaXMgcGFzdCBlbmQhXG4iLAo+ICAgICAg ICAgICAgICAgICAgICAgIGVsZi0+bmFtZSwgc3ltbmR4KTsKPiAgICAgICAgICAgICAgcmV0dXJu IC1FSU5WQUw7Cj4gICAgICAgICAgfQo+ICsgICAgICAgIGVsc2UgaWYgKCAhZWxmLT5zeW1bc3lt bmR4XS5zeW0gKQo+ICsgICAgICAgIHsKPiArICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJS LCBMSVZFUEFUQ0ggIiVzOiBObyBzeW1ib2xAJXVcbiIsCj4gKyAgICAgICAgICAgICAgICAgICAg ZWxmLT5uYW1lLCBzeW1uZHgpOwo+ICsgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiArICAg ICAgICB9Cj4KPiAgICAgICAgICB2YWwgPSByLT5yX2FkZGVuZCArIGVsZi0+c3ltW3N5bW5keF0u c3ltLT5zdF92YWx1ZTsKPgo+CgotLSAKSnVsaWVuIEdyYWxsCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1k ZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK