* [PATCH 0/2] Fix regression on suspend on opening
@ 2010-10-14 12:35 Dmitriy Paliy
2010-10-14 12:35 ` [PATCH 1/2] " Dmitriy Paliy
2010-10-14 12:35 ` [PATCH 2/2] Code cleanup: immidiately to immediately in comments Dmitriy Paliy
0 siblings, 2 replies; 3+ messages in thread
From: Dmitriy Paliy @ 2010-10-14 12:35 UTC (permalink / raw)
To: linux-bluetooth
Hi,
This fixes regression when doing suspend on opening obex stream. If
obex_write_stream returns length of buffer, it is treated as error
reponse, which is not correct.
A typo is fixed in comments as well.
Br,
Dmitriy
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] Fix regression on suspend on opening
2010-10-14 12:35 [PATCH 0/2] Fix regression on suspend on opening Dmitriy Paliy
@ 2010-10-14 12:35 ` Dmitriy Paliy
2010-10-14 12:35 ` [PATCH 2/2] Code cleanup: immidiately to immediately in comments Dmitriy Paliy
1 sibling, 0 replies; 3+ messages in thread
From: Dmitriy Paliy @ 2010-10-14 12:35 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Dmitriy Paliy
This fixes regression on suspend on opening when obex_write_stream
returns length of buffer, which is treated as error response
afterwards.
---
src/obex.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/obex.c b/src/obex.c
index d1ac339..4e1db9c 100644
--- a/src/obex.c
+++ b/src/obex.c
@@ -683,7 +683,7 @@ add_header:
os->offset += len;
- return len;
+ return 0;
}
static gboolean handle_async_io(void *object, int flags, int err,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] Code cleanup: immidiately to immediately in comments
2010-10-14 12:35 [PATCH 0/2] Fix regression on suspend on opening Dmitriy Paliy
2010-10-14 12:35 ` [PATCH 1/2] " Dmitriy Paliy
@ 2010-10-14 12:35 ` Dmitriy Paliy
1 sibling, 0 replies; 3+ messages in thread
From: Dmitriy Paliy @ 2010-10-14 12:35 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Dmitriy Paliy
---
src/obex.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/obex.c b/src/obex.c
index 4e1db9c..5f6ad47 100644
--- a/src/obex.c
+++ b/src/obex.c
@@ -818,7 +818,7 @@ static void cmd_get(struct obex_session *os, obex_t *obex, obex_object_t *obj)
OBEX_ObjectAddHeader (obex, obj, OBEX_HDR_BODY,
hd, 0, OBEX_FL_STREAM_START);
- /* Try to write to stream and suspend the stream immidiately
+ /* Try to write to stream and suspend the stream immediately
* if no data available to send. */
err = obex_write_stream(os, obex, obj);
if (err == -EAGAIN) {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-14 12:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-14 12:35 [PATCH 0/2] Fix regression on suspend on opening Dmitriy Paliy
2010-10-14 12:35 ` [PATCH 1/2] " Dmitriy Paliy
2010-10-14 12:35 ` [PATCH 2/2] Code cleanup: immidiately to immediately in comments Dmitriy Paliy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.