From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756898Ab0JOVNt (ORCPT ); Fri, 15 Oct 2010 17:13:49 -0400 Received: from casper.infradead.org ([85.118.1.10]:52433 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755970Ab0JOVNt convert rfc822-to-8bit (ORCPT ); Fri, 15 Oct 2010 17:13:49 -0400 Subject: Re: [PATCH 5/9] jump label: Add register_jump_label_key/unregister_jump_label_key From: Peter Zijlstra To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Frederic Weisbecker , Jason Baron In-Reply-To: <1287176974.16971.3.camel@gandalf.stny.rr.com> References: <20101015200949.134732894@goodmis.org> <20101015201036.923619508@goodmis.org> <1287176595.1998.116.camel@laptop> <1287176974.16971.3.camel@gandalf.stny.rr.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Fri, 15 Oct 2010 23:13:35 +0200 Message-ID: <1287177215.1998.121.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-10-15 at 17:09 -0400, Steven Rostedt wrote: > On Fri, 2010-10-15 at 23:03 +0200, Peter Zijlstra wrote: > > > Urgh, this sucks.. :-( > > > > So now we have to actually track all JUMP_LABEL() sites and call > > register muck on them.. even though we already track them through the > > special data section. > > > > Is there really no way around this? > > I'll take a look to see if we can monkey with magic and automate it. So the problem is something like: core kernel: jump_label_enable() module: JUMP_LABEL() And then because we don't have a proper __jump_table section, the jump_label_enable() won't properly work? Why not let jump_label_enable() add a dummy entry with the enabled bit and once you load the module merge the real entry into it.