From: Mike Frysinger <vapier@gentoo.org>
To: linux-mmc@vger.kernel.org,
Adrian Hunter <adrian.hunter@nokia.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
linux-kernel@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
Grant Likely <grant.likely@secretlab.ca>,
Anton Vorontsov <avorontsov@mvista.com>,
Ernst Schwab <eschwab@online.de>,
Sonic Zhang <sonic.zhang@analog.com>, Chris Ball <cjb@laptop.org>
Subject: [PATCH] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI.
Date: Sat, 16 Oct 2010 17:19:36 -0400 [thread overview]
Message-ID: <1287263976-9578-1-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <20100827203639.GT23079@void.printf.net>
From: Sonic Zhang <sonic.zhang@analog.com>
SPI bus is not reliable on all platforms when doing large data transfer.
Current mmc spi driver fails SD read/write command immediately, if
occasional CRC error is reported by SD device. This patch makes the
operation recover from the CRC error by doing last SD command again.
The retry count is set to 5 to ensure the driver pass any stress test.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
[cjb: fixed merge conflict against current Linus]
Signed-off-by: Chris Ball <cjb@laptop.org>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
Andrew: we posted this months ago with no feedback ... could you pick it up ?
drivers/mmc/host/mmc_spi.c | 22 ++++++++++++++++++++++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 62a3582..fbd673e 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -1055,6 +1055,8 @@ static void mmc_spi_request(struct mmc_host *mmc, struct mmc_request *mrq)
{
struct mmc_spi_host *host = mmc_priv(mmc);
int status = -EINVAL;
+ int crc_retry = 5;
+ struct mmc_command stop;
#ifdef DEBUG
/* MMC core and layered drivers *MUST* issue SPI-aware commands */
@@ -1087,10 +1089,30 @@ static void mmc_spi_request(struct mmc_host *mmc, struct mmc_request *mrq)
/* request exclusive bus access */
spi_bus_lock(host->spi->master);
+ crc_recover:
/* issue command; then optionally data and stop */
status = mmc_spi_command_send(host, mrq, mrq->cmd, mrq->data != NULL);
if (status == 0 && mrq->data) {
mmc_spi_data_do(host, mrq->cmd, mrq->data, mrq->data->blksz);
+
+ /*
+ * SPI bus is not reliable when doing large data transfer.
+ * If occasional crc error is reported by SD device when do
+ * data read/write over SPI, it can be recovered by doing
+ * last SD command again. The retry count is set to 5 to
+ * ensure the driver pass any stress test.
+ */
+ if (mrq->data->error == -EILSEQ && crc_retry) {
+ stop.opcode = MMC_STOP_TRANSMISSION;
+ stop.arg = 0;
+ stop.flags = MMC_RSP_SPI_R1B | MMC_RSP_R1B | MMC_CMD_AC;
+
+ status = mmc_spi_command_send(host, mrq, &stop, 0);
+ crc_retry--;
+ mrq->data->error = 0;
+ goto crc_recover;
+ }
+
if (mrq->stop)
status = mmc_spi_command_send(host, mrq, mrq->stop, 0);
else
--
1.7.3.1
next prev parent reply other threads:[~2010-10-16 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-12 7:50 [PATCH v2] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI sonic zhang
2010-07-16 10:51 ` Sonic Zhang
2010-07-16 10:51 ` Sonic Zhang
2010-07-16 15:41 ` Mike Frysinger
2010-07-16 15:41 ` Mike Frysinger
2010-08-27 20:36 ` [PATCH RESEND] " Chris Ball
2010-10-16 21:19 ` Mike Frysinger [this message]
2010-10-16 23:01 ` [PATCH] " Chris Ball
2010-10-16 23:11 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2010-07-09 8:03 sonic zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287263976-9578-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=avorontsov@mvista.com \
--cc=cjb@laptop.org \
--cc=dbrownell@users.sourceforge.net \
--cc=eschwab@online.de \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sonic.zhang@analog.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.