All of lore.kernel.org
 help / color / mirror / Atom feed
From: Onkalo Samu <samu.p.onkalo@nokia.com>
To: gregkh@suse.de, Alan Cox <alan@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: sysfs and power management
Date: Wed, 27 Oct 2010 13:59:03 +0300	[thread overview]
Message-ID: <1288177143.12206.22.camel@4fid08082> (raw)

Hi

I have recently sent couple of sensor drivers to kernel.
Interface is purely sysfs based. The hard part is to get
power management to work reasonable way.

With /dev/* interface power management is quite easy to do since
driver gets clear open and release calls. With sysfs, there is only
read / write methods available.
My solution has been separate sysfs entry which controls operating
state. However, there are some problems with that.
In case of boolean type enable / disable control, there must be
only one userspace component which decides sensor state.
In case of counting type of control, there is a change that
sensor is permanently left on if the userspace component crashes.
This would lead to unbalanced enable / disable count.

If the sensor functionality is based on interrupts (like threshold
interrupt), it may take long time before there is any activity.
In this kind of case timeout from the previous sysfs access doesn't make
much sense. 
I started to wonder if it makes sense to enhance sysfs so that it
optionally prodives open / close call backs. Internally sysfs has some 
bookkeeping about the refcount but this is not visible to the driver.
Of course majority of the sysfs users doesn't need that at all
and for them this is just overhead. 

Is it out of the question to provide call back to driver when 
some sysfs entry is opened (first time) and when refcnt goes back
to 0?

Regards,
Samu



             reply	other threads:[~2010-10-27 10:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27 10:59 Onkalo Samu [this message]
2010-10-27 11:48 ` sysfs and power management Alan Cox
2010-10-27 13:43   ` samu.p.onkalo
2010-10-27 14:28     ` Alan Cox
2010-10-29 19:50       ` Greg KH
2010-10-30 14:00         ` Henrique de Moraes Holschuh
2010-10-31 11:57           ` Onkalo Samu
2010-10-31 14:25             ` Greg KH
2010-11-01 10:41               ` Onkalo Samu
2010-11-01 16:57                 ` Alan Cox
2010-11-01 18:07                   ` Greg KH
2010-11-03  9:44                     ` Alan Cox
2010-11-03 10:48                       ` samu.p.onkalo
2010-11-03 13:09                       ` Greg KH
2010-11-03 15:00                         ` samu.p.onkalo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288177143.12206.22.camel@4fid08082 \
    --to=samu.p.onkalo@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.