All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Partington <mparting@lexmark.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Standalone Apps: Standalone apps should need only exports.h.
Date: Wed, 27 Oct 2010 12:12:54 -0400	[thread overview]
Message-ID: <1288195974-23100-1-git-send-email-mparting@lexmark.com> (raw)

From: Mike Partington <mparting@windstar.lpdev.prtdev.lexmark.com>

Modify exports.h to remove its dependencies on other files, thus
enabling standalone apps to require only exports.h from the U-Boot
source tree.  This appears to be the intent based on the following
note: http://lists.denx.de/pipermail/u-boot/2010-January/067174.html

Signed-off-by: Mike Partington <mparting@windstar.lpdev.prtdev.lexmark.com>
---
 examples/standalone/atmel_df_pow2.c |    1 +
 examples/standalone/stubs.c         |    1 +
 include/exports.h                   |    5 +----
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/examples/standalone/atmel_df_pow2.c b/examples/standalone/atmel_df_pow2.c
index b5b4503..2e14aba 100644
--- a/examples/standalone/atmel_df_pow2.c
+++ b/examples/standalone/atmel_df_pow2.c
@@ -8,6 +8,7 @@
 
 #include <common.h>
 #include <exports.h>
+#include <spi.h>
 
 #define CMD_ID    0x9f
 #define CMD_STAT  0xd7
diff --git a/examples/standalone/stubs.c b/examples/standalone/stubs.c
index 2d2e709..1ebe43b 100644
--- a/examples/standalone/stubs.c
+++ b/examples/standalone/stubs.c
@@ -1,3 +1,4 @@
+#include <common.h>
 #include <exports.h>
 
 #ifndef GCC_VERSION
diff --git a/include/exports.h b/include/exports.h
index 7404a7c..01b83dc 100644
--- a/include/exports.h
+++ b/include/exports.h
@@ -3,8 +3,6 @@
 
 #ifndef __ASSEMBLY__
 
-#include <common.h>
-
 /* These are declarations of exported functions available in C code */
 unsigned long get_version(void);
 int  getc(void);
@@ -12,7 +10,7 @@ int  tstc(void);
 void putc(const char);
 void puts(const char*);
 int printf(const char* fmt, ...);
-void install_hdlr(int, interrupt_handler_t*, void*);
+void install_hdlr(int, void (*interrupt_handler_t)(void *), void*);
 void free_hdlr(int);
 void *malloc(size_t);
 void free(void*);
@@ -30,7 +28,6 @@ int ustrtoul(const char *cp, char **endp, unsigned int base);
 int i2c_write (uchar, uint, int , uchar* , int);
 int i2c_read (uchar, uint, int , uchar* , int);
 #endif
-#include <spi.h>
 
 void app_startup(char * const *);
 
-- 
1.7.3.5.g4a3b

             reply	other threads:[~2010-10-27 16:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27 16:12 Mike Partington [this message]
2010-10-27 19:44 ` [U-Boot] [PATCH] Standalone Apps: Standalone apps should need only exports.h Rogan Dawes
2010-10-27 20:31   ` [U-Boot] [PATCH v2] " Mike Partington
2011-12-06 19:53     ` Wolfgang Denk
2011-12-07  3:38       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288195974-23100-1-git-send-email-mparting@lexmark.com \
    --to=mparting@lexmark.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.