* [PATCH] Fix missing dependency of PCH_GBE driver
@ 2010-10-28 12:16 Steven Rostedt
2010-10-28 17:16 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2010-10-28 12:16 UTC (permalink / raw)
To: LKML, netdev
Cc: David S. Miller, Dan Carpenter, Masayuki Ohtake, Andrew Morton
While doing some randconfigs I stumbled across this build error:
ERROR: "mii_ethtool_gset" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
ERROR: "generic_mii_ioctl" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
ERROR: "mii_nway_restart" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
ERROR: "mii_check_gmii_support" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
ERROR: "mii_link_ok" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
ERROR: "mii_ethtool_sset" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
The config option PCH_GBE is missing the dependency of MII.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 9334539..cf9769c 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2540,7 +2540,7 @@ source "drivers/net/stmmac/Kconfig"
config PCH_GBE
tristate "PCH Gigabit Ethernet"
- depends on PCI
+ depends on PCI && MII
---help---
This is a gigabit ethernet driver for Topcliff PCH.
Topcliff PCH is the platform controller hub that is used in Intel's
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix missing dependency of PCH_GBE driver
2010-10-28 12:16 [PATCH] Fix missing dependency of PCH_GBE driver Steven Rostedt
@ 2010-10-28 17:16 ` David Miller
2010-10-28 17:31 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2010-10-28 17:16 UTC (permalink / raw)
To: rostedt; +Cc: linux-kernel, netdev, error27, masa-korg, akpm
From: Steven Rostedt <rostedt@goodmis.org>
Date: Thu, 28 Oct 2010 08:16:29 -0400
> While doing some randconfigs I stumbled across this build error:
>
> ERROR: "mii_ethtool_gset" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "generic_mii_ioctl" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "mii_nway_restart" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "mii_check_gmii_support" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "mii_link_ok" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
> ERROR: "mii_ethtool_sset" [drivers/net/pch_gbe/pch_gbe.ko] undefined!
>
> The config option PCH_GBE is missing the dependency of MII.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
The canonical way to handle this is to use 'select'. Thus,
I've committed the following to fix this.
Thanks.
--------------------
pch_gbe: Select MII.
Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 77c1fab..f24179d 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2520,6 +2520,7 @@ source "drivers/net/stmmac/Kconfig"
config PCH_GBE
tristate "PCH Gigabit Ethernet"
depends on PCI
+ select MII
---help---
This is a gigabit ethernet driver for Topcliff PCH.
Topcliff PCH is the platform controller hub that is used in Intel's
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix missing dependency of PCH_GBE driver
2010-10-28 17:16 ` David Miller
@ 2010-10-28 17:31 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2010-10-28 17:31 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, netdev, error27, masa-korg, akpm
On Thu, 2010-10-28 at 10:16 -0700, David Miller wrote:
> The canonical way to handle this is to use 'select'. Thus,
> I've committed the following to fix this.
Yeah, I was thinking that too after I posted it.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-28 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-28 12:16 [PATCH] Fix missing dependency of PCH_GBE driver Steven Rostedt
2010-10-28 17:16 ` David Miller
2010-10-28 17:31 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.