From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] Fix ia64 tools build Date: Mon, 1 Nov 2010 09:28:15 +0000 Message-ID: <1288603695.13236.4314.camel@zakaz.uk.xensource.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: KUWAMURA Shin'ya , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Mon, 2010-11-01 at 09:21 +0000, Keir Fraser wrote: > On 01/11/2010 08:39, "KUWAMURA Shin'ya" wrote: > > > Hi Keir and Ian, > > > >>>>>> On Fri, 29 Oct 2010 08:55:31 +0100 > >>>>>> keir@xen.org(Keir Fraser) said: > >> > >> I think it would ne neater to have your own > >> tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from > >> Xen's acenv.h (e.g., dependent on __XEN_TOOLS__). > > > > I created a patch for Keir's first advice. > > > > This patch introduces ac_ia64_tools.h and it only defines identifiers > > in order to avoid compilation errors. > > > > Because all identifiers can be easily led from the error message, > > it is trivial. > > > > Any comments? > > I'll apply this if IanC finds it acceptable. Subject to the addition of a license boiler plate at the top of ltools/libxc/ia64/ac_ia64_tools.h, either the LGPLv2 one used through out libxc or something compatible, it is fine with me. Ian. > > -- Keir > > > Best regards, > >