From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Olsa Subject: [PATCH 0/3] rcu - removing superfluous rcu_read_lock_held check Date: Mon, 1 Nov 2010 20:15:06 +0100 Message-ID: <1288638909-10541-1-git-send-email-jolsa@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org, paul.moore-VXdhtT5mjnY@public.gmane.org, johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org, dipankar-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Jiri Olsa , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: containers.vger.kernel.org hi, the rcu_dereference_check is defined as #define rcu_dereference_check(p, c) \ __rcu_dereference_check((p), rcu_read_lock_held() || (c), __rcu) so the caller does not need to specify rcu_read_lock_held() condition. Several places in kernel are spcifying rcu_read_lock_held as rcu_dereference_check condition parameter. I separated them into 3 patches: 1/3 - cgroup - removing superfluous rcu_read_lock_held check 2/3 - kernel,cred,kvm,security - removing superfluous rcu_read_lock_held check 3/3 - net - removing superfluous rcu_read_lock_held check sry if I might missed or added somebody wrongly to recipients wbr, jirka Signed-off-by: Jiri Olsa --- include/linux/cgroup.h | 1 - include/linux/cred.h | 1 - include/linux/fdtable.h | 1 - include/linux/kvm_host.h | 1 - include/linux/rtnetlink.h | 3 +-- include/net/sock.h | 3 +-- kernel/cgroup.c | 6 ++---- kernel/exit.c | 1 - kernel/pid.c | 1 - kernel/rcutorture.c | 2 -- net/mac80211/sta_info.c | 4 ---- net/netlabel/netlabel_domainhash.c | 3 +-- net/netlabel/netlabel_unlabeled.c | 3 +-- security/keys/keyring.c | 1 - 14 files changed, 6 insertions(+), 25 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751719Ab0KATQx (ORCPT ); Mon, 1 Nov 2010 15:16:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534Ab0KATQj (ORCPT ); Mon, 1 Nov 2010 15:16:39 -0400 From: Jiri Olsa To: dhowells@redhat.com, lizf@cn.fujitsu.com, paul.moore@hp.com, johannes@sipsolutions.net, dipankar@in.ibm.com Cc: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, kvm@vger.kernel.org, Jiri Olsa Subject: [PATCH 0/3] rcu - removing superfluous rcu_read_lock_held check Date: Mon, 1 Nov 2010 20:15:06 +0100 Message-Id: <1288638909-10541-1-git-send-email-jolsa@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, the rcu_dereference_check is defined as #define rcu_dereference_check(p, c) \ __rcu_dereference_check((p), rcu_read_lock_held() || (c), __rcu) so the caller does not need to specify rcu_read_lock_held() condition. Several places in kernel are spcifying rcu_read_lock_held as rcu_dereference_check condition parameter. I separated them into 3 patches: 1/3 - cgroup - removing superfluous rcu_read_lock_held check 2/3 - kernel,cred,kvm,security - removing superfluous rcu_read_lock_held check 3/3 - net - removing superfluous rcu_read_lock_held check sry if I might missed or added somebody wrongly to recipients wbr, jirka Signed-off-by: Jiri Olsa --- include/linux/cgroup.h | 1 - include/linux/cred.h | 1 - include/linux/fdtable.h | 1 - include/linux/kvm_host.h | 1 - include/linux/rtnetlink.h | 3 +-- include/net/sock.h | 3 +-- kernel/cgroup.c | 6 ++---- kernel/exit.c | 1 - kernel/pid.c | 1 - kernel/rcutorture.c | 2 -- net/mac80211/sta_info.c | 4 ---- net/netlabel/netlabel_domainhash.c | 3 +-- net/netlabel/netlabel_unlabeled.c | 3 +-- security/keys/keyring.c | 1 - 14 files changed, 6 insertions(+), 25 deletions(-)