All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: linux-wireless@vger.kernel.org
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Hin-Tak Leung <htl10@users.sourceforge.net>,
	John W Linville <linville@tuxdriver.com>,
	Herton Ronaldo Krzesinski <herton@mandriva.com.br>,
	seno <senada@t-online.de>
Subject: [PATCH 8/9] rtl8187: remove uneeded setting of anaparam write
Date: Mon,  1 Nov 2010 22:59:38 -0200	[thread overview]
Message-ID: <1288659579-4986-9-git-send-email-herton@mandriva.com.br> (raw)
In-Reply-To: <1288659579-4986-1-git-send-email-herton@mandriva.com.br>

Usually you set RTL818X_CONFIG3_ANAPARAM_WRITE when you are going to
change/write ANAPARAM registers. But in current initialization of
RTL8187B there is a place where ANAPARAM_WRITE bit is set without any
ANAPARAM register being written, without reason, so remove it.

Signed-off-by: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: seno <senada@t-online.de>
---
 drivers/net/wireless/rtl818x/rtl8187_dev.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/rtl818x/rtl8187_dev.c b/drivers/net/wireless/rtl818x/rtl8187_dev.c
index c0c75aa..4448647 100644
--- a/drivers/net/wireless/rtl818x/rtl8187_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8187_dev.c
@@ -814,14 +814,6 @@ static int rtl8187b_init_hw(struct ieee80211_hw *dev)
 	/* RFSW_CTRL register */
 	rtl818x_iowrite16_idx(priv, (__le16 *)0xFF72, 0x569A, 2);
 
-	rtl818x_iowrite8(priv, &priv->map->EEPROM_CMD,
-			 RTL818X_EEPROM_CMD_CONFIG);
-	reg = rtl818x_ioread8(priv, &priv->map->CONFIG3);
-	reg |= RTL818X_CONFIG3_ANAPARAM_WRITE;
-	rtl818x_iowrite8(priv, &priv->map->CONFIG3, reg);
-	rtl818x_iowrite8(priv, &priv->map->EEPROM_CMD,
-			 RTL818X_EEPROM_CMD_NORMAL);
-
 	rtl818x_iowrite16(priv, &priv->map->RFPinsOutput, 0x0480);
 	rtl818x_iowrite16(priv, &priv->map->RFPinsSelect, 0x2488);
 	rtl818x_iowrite16(priv, &priv->map->RFPinsEnable, 0x1FFF);
-- 
1.7.3.2


  parent reply	other threads:[~2010-11-02  1:00 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02  0:59 [PATCH 0/9] rtl8187: start cleanup/revisiting code Herton Ronaldo Krzesinski
2010-11-02  0:59 ` [PATCH 1/9] rtl8187: remove redundant initialization of ARFR Herton Ronaldo Krzesinski
2010-11-02  0:59 ` [PATCH 2/9] rtl8187: remove setting of beacon/atim registers from initialization Herton Ronaldo Krzesinski
2010-11-02  0:59 ` [PATCH 3/9] rtl8187: fix wrong register initialization in 8187B Herton Ronaldo Krzesinski
2010-11-02  2:42   ` Hin-Tak Leung
2010-11-02  2:46     ` Larry Finger
2010-11-02  3:01       ` Herton Ronaldo Krzesinski
2010-11-02 23:48         ` Rogerio Luz Coelho
2010-11-02 23:57           ` Larry Finger
2010-11-03  0:01             ` Rogerio Luz Coelho
2010-11-03  0:45               ` Larry Finger
2010-11-03  1:06                 ` Rogerio Luz Coelho
2010-11-03  1:44                   ` Larry Finger
2010-11-04 14:06                     ` Hin-Tak Leung
2010-11-04 14:15               ` Hin-Tak Leung
2010-11-05 20:30                 ` Rogerio Luz Coelho
2010-11-03 13:28           ` Herton Ronaldo Krzesinski
2010-11-04  2:41             ` Rogerio Luz Coelho
2010-11-04  2:57               ` Larry Finger
2010-11-02  3:01       ` Hin-Tak Leung
2010-11-02  0:59 ` [PATCH 4/9] rtl8187: avoid redundant write to register FF72 (RFSW_CTRL) Herton Ronaldo Krzesinski
2010-11-02  0:59 ` [PATCH 5/9] rtl8187: move pll reset at start out of ANAPARAM write Herton Ronaldo Krzesinski
2010-11-02  0:59 ` [PATCH 6/9] rtl8187: don't set RTL818X_CONFIG3_GNT_SELECT flag on 8187B Herton Ronaldo Krzesinski
2010-11-02  0:59 ` [PATCH 7/9] rtl8187: consolidate anaparam on/off write sequences Herton Ronaldo Krzesinski
2010-11-02  0:59 ` Herton Ronaldo Krzesinski [this message]
2010-11-02  0:59 ` [PATCH 9/9] rtl8187: restore anaparam registers after reset with 8187B Herton Ronaldo Krzesinski
2010-11-04 15:30   ` Thadeu Lima de Souza Cascardo
2010-11-04 15:50     ` Herton Ronaldo Krzesinski
2010-11-05 19:45       ` Thadeu Lima de Souza Cascardo
2010-11-07  1:07         ` Herton Ronaldo Krzesinski
2010-11-07  1:29           ` Hin-Tak Leung
2010-11-07  3:28             ` Herton Ronaldo Krzesinski
2010-11-07  3:45               ` Larry Finger
2010-11-02  1:02 ` [PATCH 0/9] rtl8187: start cleanup/revisiting code Herton Ronaldo Krzesinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288659579-4986-9-git-send-email-herton@mandriva.com.br \
    --to=herton@mandriva.com.br \
    --cc=Larry.Finger@lwfinger.net \
    --cc=htl10@users.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=senada@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.