From: yangsheng <sheng.yang@oracle.com>
To: linux-ext4@vger.kernel.org
Cc: andreas.dilger@oracle.com, linux-fsdevel@vger.kernel.org,
yangsheng <sheng.yang@oracle.com>
Subject: [PATCH resend] jbd2_stats_proc_init wrong place.
Date: Tue, 16 Nov 2010 15:31:44 +0800 [thread overview]
Message-ID: <1289892704-27147-1-git-send-email-sheng.yang@oracle.com> (raw)
The jbd2_stats_proc_init() was placed on wrong location in
jbd2_journal_init_dev(). This may cause /proc/fs/jdb2/<dev>/*
cannot be created when using external journal device.
Reviewed-by: Andreas Dilger <andreas.dilger@oracle.com>
---
---
fs/jbd2/journal.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index c590d15..f837ba9 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -899,6 +899,14 @@ journal_t * jbd2_journal_init_dev(struct block_device *bdev,
/* journal descriptor can store up to n blocks -bzzz */
journal->j_blocksize = blocksize;
+ journal->j_dev = bdev;
+ journal->j_fs_dev = fs_dev;
+ journal->j_blk_offset = start;
+ journal->j_maxlen = len;
+ bdevname(journal->j_dev, journal->j_devname);
+ p = journal->j_devname;
+ while ((p = strchr(p, '/')))
+ *p = '!';
jbd2_stats_proc_init(journal);
n = journal->j_blocksize / sizeof(journal_block_tag_t);
journal->j_wbufsize = n;
@@ -908,14 +916,6 @@ journal_t * jbd2_journal_init_dev(struct block_device *bdev,
__func__);
goto out_err;
}
- journal->j_dev = bdev;
- journal->j_fs_dev = fs_dev;
- journal->j_blk_offset = start;
- journal->j_maxlen = len;
- bdevname(journal->j_dev, journal->j_devname);
- p = journal->j_devname;
- while ((p = strchr(p, '/')))
- *p = '!';
bh = __getblk(journal->j_dev, start, journal->j_blocksize);
if (!bh) {
--
1.7.2.3
next reply other threads:[~2010-11-16 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 7:31 yangsheng [this message]
2010-11-16 11:40 ` [PATCH resend] jbd2_stats_proc_init wrong place Lukas Czerner
2010-11-16 21:01 ` Ted Ts'o
2010-11-17 8:17 ` yangsheng
2010-11-18 2:52 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289892704-27147-1-git-send-email-sheng.yang@oracle.com \
--to=sheng.yang@oracle.com \
--cc=andreas.dilger@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.