From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com>
Subject: Re: [PATCH v2 2/3] eal: add new rte color definition
Date: Sat, 15 Dec 2018 15:15:42 +0100
Message-ID: <128d5503-af19-c9bb-d59c-43b71471f9c4@ericsson.com>
References: <20181123165423.134922-1-jasvinder.singh@intel.com>
 <1544193116-7058-2-git-send-email-reshma.pattan@intel.com>
 <2601191342CEEE43887BDE71AB977258010D8BA5F8@IRSMSX106.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 "Singh, Jasvinder" <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by dpdk.org (Postfix) with ESMTP id 24BF01B92D
 for <dev@dpdk.org>; Sat, 15 Dec 2018 15:15:45 +0100 (CET)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id 7AD7C40030
 for <dev@dpdk.org>; Sat, 15 Dec 2018 15:15:44 +0100 (CET)
In-Reply-To: <2601191342CEEE43887BDE71AB977258010D8BA5F8@IRSMSX106.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2018-12-15 00:35, Ananyev, Konstantin wrote:
> Hi Reshma,
> 
>> diff --git a/lib/librte_eal/common/include/rte_color.h b/lib/librte_eal/common/include/rte_color.h
>> new file mode 100644
>> index 000000000..f4387071b
>> --- /dev/null
>> +++ b/lib/librte_eal/common/include/rte_color.h
>> @@ -0,0 +1,18 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright(c) 2018 Intel Corporation
>> + */
>> +
>> +#ifndef _RTE_COLOR_H_
>> +#define _RTE_COLOR_H_
>> +
>> +/**
>> + * Color
>> + */
>> +enum rte_color {
>> +	RTE_COLOR_GREEN = 0, /**< Green */
>> +	RTE_COLOR_YELLOW, /**< Yellow */
>> +	RTE_COLOR_RED, /**< Red */
>> +	RTE_COLORS /**< Number of colors */
>> +};
> 
> Does it really belong to EAL?
> Konstantin
> 

If this is supposed to be a generic type, we definitely need 
RTE_COLOR_BLACK as well, or RTE_COLOR_VERY_VERY_DARK_GREY.

/Batman