From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
acme@redhat.com, mingo@elte.hu, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/2] perf: Fix compilation on gcc 4.0.2
Date: Thu, 18 Nov 2010 14:38:09 +0100 [thread overview]
Message-ID: <1290087489.2781.121.camel@edumazet-laptop> (raw)
In-Reply-To: <20101118133112.GC12667@basil.fritz.box>
Le jeudi 18 novembre 2010 à 14:31 +0100, Andi Kleen a écrit :
> > Should we be using more of the kernel makefile magic to detect this?
>
> In theory yes, but the two warnings didn't seem to be too useful
> to me so it's probably not worth it just for those two.
>
> -Andi
>
Is the second case because of the __always_inline in
util/include/linux/bitops.h ?
Not sure why its needed for test_bit() ?
diff --git a/tools/perf/util/include/linux/bitops.h b/tools/perf/util/include/linux/bitops.h
index bb4ac2e..a1459f2 100644
--- a/tools/perf/util/include/linux/bitops.h
+++ b/tools/perf/util/include/linux/bitops.h
@@ -13,7 +13,7 @@ static inline void set_bit(int nr, unsigned long *addr)
addr[nr / BITS_PER_LONG] |= 1UL << (nr % BITS_PER_LONG);
}
-static __always_inline int test_bit(unsigned int nr, const unsigned long *addr)
+static inline int test_bit(unsigned int nr, const unsigned long *addr)
{
return ((1UL << (nr % BITS_PER_LONG)) &
(((unsigned long *)addr)[nr / BITS_PER_LONG])) != 0;
next prev parent reply other threads:[~2010-11-18 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 10:50 Some perf user space improvements Andi Kleen
2010-11-18 10:51 ` [PATCH 1/2] perf: Fix compilation on gcc 4.0.2 Andi Kleen
2010-11-18 11:15 ` Peter Zijlstra
2010-11-18 13:31 ` Andi Kleen
2010-11-18 13:38 ` Eric Dumazet [this message]
2010-11-18 13:40 ` Andi Kleen
2010-11-19 9:51 ` [PATCH 1/2] perf: Fix compilation on gcc 4.0.2 v2 Andi Kleen
2010-11-18 11:53 ` [PATCH 1/2] perf: Fix compilation on gcc 4.0.2 Thomas Gleixner
2010-11-18 10:51 ` [PATCH 2/2] perf: Handle perf-versionnumber Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290087489.2781.121.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.