From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755129Ab0KVNTd (ORCPT ); Mon, 22 Nov 2010 08:19:33 -0500 Received: from service87.mimecast.com ([94.185.240.25]:54529 "HELO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753409Ab0KVNTc convert rfc822-to-8bit (ORCPT ); Mon, 22 Nov 2010 08:19:32 -0500 Subject: Re: [PATCH v2 11/20] ARM: LPAE: Add fault handling support From: Catalin Marinas To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20101122131546.GG31227@n2100.arm.linux.org.uk> References: <1289584840-18097-1-git-send-email-catalin.marinas@arm.com> <1289584840-18097-12-git-send-email-catalin.marinas@arm.com> <20101122131546.GG31227@n2100.arm.linux.org.uk> Organization: ARM Limited Date: Mon, 22 Nov 2010 13:19:27 +0000 Message-ID: <1290431967.29754.11.camel@e102109-lin.cambridge.arm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-OriginalArrivalTime: 22 Nov 2010 13:19:27.0713 (UTC) FILETIME=[E3AAE510:01CB8A47] X-MC-Unique: 110112213192901101 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2010-11-22 at 13:15 +0000, Russell King - ARM Linux wrote: > On Fri, Nov 12, 2010 at 06:00:31PM +0000, Catalin Marinas wrote: > > @@ -108,7 +113,9 @@ void show_pte(struct mm_struct *mm, unsigned long addr) > > > > pte = pte_offset_map(pmd, addr); > > printk(", *pte=%08lx", pte_val(*pte)); > > +#ifndef CONFIG_ARM_LPAE > > printk(", *ppte=%08lx", pte_val(pte[-LINUX_PTE_OFFSET])); > > +#endif > > This is an unrelated change - should it be in a different patch? It was intended to be in this patch as I couldn't find a better place. This patch sorts out the fault handling (and error reporting) for LPAE and we don't need the additional printk here. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Mon, 22 Nov 2010 13:19:27 +0000 Subject: [PATCH v2 11/20] ARM: LPAE: Add fault handling support In-Reply-To: <20101122131546.GG31227@n2100.arm.linux.org.uk> References: <1289584840-18097-1-git-send-email-catalin.marinas@arm.com> <1289584840-18097-12-git-send-email-catalin.marinas@arm.com> <20101122131546.GG31227@n2100.arm.linux.org.uk> Message-ID: <1290431967.29754.11.camel@e102109-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2010-11-22 at 13:15 +0000, Russell King - ARM Linux wrote: > On Fri, Nov 12, 2010 at 06:00:31PM +0000, Catalin Marinas wrote: > > @@ -108,7 +113,9 @@ void show_pte(struct mm_struct *mm, unsigned long addr) > > > > pte = pte_offset_map(pmd, addr); > > printk(", *pte=%08lx", pte_val(*pte)); > > +#ifndef CONFIG_ARM_LPAE > > printk(", *ppte=%08lx", pte_val(pte[-LINUX_PTE_OFFSET])); > > +#endif > > This is an unrelated change - should it be in a different patch? It was intended to be in this patch as I couldn't find a better place. This patch sorts out the fault handling (and error reporting) for LPAE and we don't need the additional printk here. -- Catalin