All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 3/3] vga: tag as not hotplugable.
Date: Tue, 30 Nov 2010 14:26:04 +0100	[thread overview]
Message-ID: <1291123564-3249-4-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1291123564-3249-1-git-send-email-kraxel@redhat.com>

This patch tags all vga cards as not hotpluggable.  The qemu
standard vga will never ever be hotpluggable.  For cirrus + vmware
it might be possible to get that work some day.  Todays we can't
handle that for a number of reasons though.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/cirrus_vga.c |    1 +
 hw/vga-pci.c    |    1 +
 hw/vmware_vga.c |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index aadc56f..1936730 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -3223,6 +3223,7 @@ static PCIDeviceInfo cirrus_vga_info = {
     .qdev.desc    = "Cirrus CLGD 54xx VGA",
     .qdev.size    = sizeof(PCICirrusVGAState),
     .qdev.vmsd    = &vmstate_pci_cirrus_vga,
+    .no_hotplug   = 1,
     .init         = pci_cirrus_vga_initfn,
     .romfile      = VGABIOS_CIRRUS_FILENAME,
     .config_write = pci_cirrus_write_config,
diff --git a/hw/vga-pci.c b/hw/vga-pci.c
index 791ca22..ce9ec45 100644
--- a/hw/vga-pci.c
+++ b/hw/vga-pci.c
@@ -110,6 +110,7 @@ static PCIDeviceInfo vga_info = {
     .qdev.name    = "VGA",
     .qdev.size    = sizeof(PCIVGAState),
     .qdev.vmsd    = &vmstate_vga_pci,
+    .no_hotplug   = 1,
     .init         = pci_vga_initfn,
     .config_write = pci_vga_write_config,
     .romfile      = "vgabios-stdvga.bin",
diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
index d0f4e1b..bcd02d2 100644
--- a/hw/vmware_vga.c
+++ b/hw/vmware_vga.c
@@ -1318,6 +1318,7 @@ static PCIDeviceInfo vmsvga_info = {
     .qdev.name    = "vmware-svga",
     .qdev.size    = sizeof(struct pci_vmsvga_state_s),
     .qdev.vmsd    = &vmstate_vmware_vga,
+    .no_hotplug   = 1,
     .init         = pci_vmsvga_initfn,
     .romfile      = "vgabios-vmware.bin",
 };
-- 
1.7.1

  parent reply	other threads:[~2010-12-01  4:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 13:26 [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for pci devices Gerd Hoffmann
2010-11-30 13:26 ` [Qemu-devel] [PATCH 1/3] pci: allow devices being tagged as not hotpluggable Gerd Hoffmann
2011-01-06 14:53   ` [Qemu-devel] " Michael S. Tsirkin
2010-11-30 13:26 ` [Qemu-devel] [PATCH 2/3] piix: tag " Gerd Hoffmann
2011-01-05 19:44   ` [Qemu-devel] " Michael S. Tsirkin
2011-01-06  8:40     ` Gerd Hoffmann
2011-01-06  9:29       ` Michael S. Tsirkin
2011-01-06 14:14         ` Gerd Hoffmann
2011-01-06 14:34           ` Michael S. Tsirkin
2011-01-06 18:45             ` Marcelo Tosatti
2011-01-07 11:42               ` Michael S. Tsirkin
2010-11-30 13:26 ` Gerd Hoffmann [this message]
2011-01-05 15:57 ` [Qemu-devel] Re: [PATCH 0/3] add hotplug opt-out option for pci devices Michael S. Tsirkin
2011-01-06 15:17   ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2010-11-18 10:45 [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices Gerd Hoffmann
2010-11-18 10:45 ` [Qemu-devel] [PATCH 3/3] vga: tag as not hotplugable Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291123564-3249-4-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.