From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756307Ab0K3TZh (ORCPT ); Tue, 30 Nov 2010 14:25:37 -0500 Received: from canuck.infradead.org ([134.117.69.58]:41761 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756255Ab0K3TZg convert rfc822-to-8bit (ORCPT ); Tue, 30 Nov 2010 14:25:36 -0500 Subject: Re: [PATCH 09/21] powerpc: Preemptible mmu_gather From: Peter Zijlstra To: Benjamin Herrenschmidt Cc: Andrea Arcangeli , Avi Kivity , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, David Miller , Hugh Dickins , Mel Gorman , Nick Piggin , Paul McKenney , Yanmin Zhang , Stephen Rothwell In-Reply-To: <1291088148.32570.342.camel@pasglop> References: <20101126143843.801484792@chello.nl> <20101126145410.771278578@chello.nl> <1291086726.32570.341.camel@pasglop> <1291088148.32570.342.camel@pasglop> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Tue, 30 Nov 2010 20:25:13 +0100 Message-ID: <1291145113.32004.1152.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2010-11-30 at 14:35 +1100, Benjamin Herrenschmidt wrote: > > This breaks embedded 64-bit build. Replace CONFIG_PPC64 with > > CONFIG_PPC_BOOK3S_64 to only hit server when you access the > > ppc64_tlb_batch in process.c since it doesn't exist for BOOK3E. > > > > This patch to fold into yours fixes it for me: > > With this fix and the other Kconfig fix, it seems to boot fine and no > obvious breakage doing simple things on G5 and a power6 machine. Awesome, thanks for your fixes, I've folded them in the respective patches. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 09/21] powerpc: Preemptible mmu_gather Date: Tue, 30 Nov 2010 20:25:13 +0100 Message-ID: <1291145113.32004.1152.camel@laptop> References: <20101126143843.801484792@chello.nl> <20101126145410.771278578@chello.nl> <1291086726.32570.341.camel@pasglop> <1291088148.32570.342.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1291088148.32570.342.camel@pasglop> Sender: owner-linux-mm@kvack.org To: Benjamin Herrenschmidt Cc: Andrea Arcangeli , Avi Kivity , Thomas Gleixner , Rik van Riel , Ingo Molnar , akpm@linux-foundation.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, David Miller , Hugh Dickins , Mel Gorman , Nick Piggin , Paul McKenney , Yanmin Zhang , Stephen Rothwell List-Id: linux-arch.vger.kernel.org On Tue, 2010-11-30 at 14:35 +1100, Benjamin Herrenschmidt wrote: > > This breaks embedded 64-bit build. Replace CONFIG_PPC64 with > > CONFIG_PPC_BOOK3S_64 to only hit server when you access the > > ppc64_tlb_batch in process.c since it doesn't exist for BOOK3E. > >=20 > > This patch to fold into yours fixes it for me: >=20 > With this fix and the other Kconfig fix, it seems to boot fine and no > obvious breakage doing simple things on G5 and a power6 machine. Awesome, thanks for your fixes, I've folded them in the respective patches. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org