From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57614 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PUnV1-0005L2-Lc
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:42:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1PUnMG-0000CO-Vv
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:33:29 -0500
Received: from mailout-de.gmx.net ([213.165.64.23]:36045 helo=mail.gmx.net)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1PUnMG-0000C9-Hc
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:33:28 -0500
Date: Mon, 20 Dec 2010 22:31:55 +0100
Message-Id: <1292880715$3178@local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
From: Sebastian Herbszt <herbszt@gmx.de>
Subject: [Qemu-devel] [PATCH] e1000: use pci_config_set_revision()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Sebastian Herbszt <herbszt@gmx.de>

Use pci_config_set_revision().

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>

diff --git a/hw/e1000.c b/hw/e1000.c
index af101bd..7bad51a 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -1116,7 +1116,7 @@ static int pci_e1000_init(PCIDevice *pci_dev)
     pci_config_set_device_id(pci_conf, E1000_DEVID);
     /* TODO: we have no capabilities, so why is this bit set? */
     pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST);
-    pci_conf[PCI_REVISION_ID] = 0x03;
+    pci_config_set_revision(pci_conf, 0x03);
     pci_config_set_class(pci_conf, PCI_CLASS_NETWORK_ETHERNET);
     /* TODO: RST# value should be 0, PCI spec 6.2.4 */
     pci_conf[PCI_CACHE_LINE_SIZE] = 0x10;