From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59396 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PUnZP-0000ed-K1
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:47:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1PUnZN-00033n-Pn
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:47:03 -0500
Received: from mailout-de.gmx.net ([213.165.64.22]:54915 helo=mail.gmx.net)
	by eggs.gnu.org with smtp (Exim 4.71)
	(envelope-from <herbszt@gmx.de>) id 1PUnZN-00033e-CX
	for qemu-devel@nongnu.org; Mon, 20 Dec 2010 16:47:01 -0500
Date: Mon, 20 Dec 2010 22:45:25 +0100
Message-Id: <1292881525$2258@local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
From: Sebastian Herbszt <herbszt@gmx.de>
Subject: [Qemu-devel] [PATCH] usb-uhci: use pci_config_set_revision()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Sebastian Herbszt <herbszt@gmx.de>

Use pci_config_set_revision().

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>

diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index b9b822f..5b3bf21 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -1106,7 +1106,7 @@ static int usb_uhci_common_initfn(UHCIState *s)
     uint8_t *pci_conf = s->dev.config;
     int i;
 
-    pci_conf[PCI_REVISION_ID] = 0x01; // revision number
+    pci_config_set_revision(pci_conf, 0x01); // revision number
     pci_conf[PCI_CLASS_PROG] = 0x00;
     pci_config_set_class(pci_conf, PCI_CLASS_SERIAL_USB);
     /* TODO: reset value should be 0. */