From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v11 5/8] ethdev: add speed capabilities Date: Fri, 18 Mar 2016 11:12:02 +0100 Message-ID: <12935703.N0x8FXtEJv@xps13> References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com> <1458238145-7496-6-git-send-email-thomas.monjalon@6wind.com> <20160318092823.GJ27079@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: marcdevel@gmail.com, bruce.richardson@intel.com, declan.doherty@intel.com, konstantin.ananyev@intel.com, wenzhuo.lu@intel.com, helin.zhang@intel.com, jing.d.chen@intel.com, harish.patil@qlogic.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, vido@cesnet.cz, alejandro.lucero@netronome.com, dev@dpdk.org To: Adrien Mazarguil Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 9CF1E2E8D for ; Fri, 18 Mar 2016 11:13:33 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id p65so29886740wmp.0 for ; Fri, 18 Mar 2016 03:13:33 -0700 (PDT) In-Reply-To: <20160318092823.GJ27079@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-18 10:28, Adrien Mazarguil: > On Thu, Mar 17, 2016 at 07:09:02PM +0100, Thomas Monjalon wrote: > > --- a/drivers/net/mlx4/mlx4.c > > +++ b/drivers/net/mlx4/mlx4.c > > @@ -4301,6 +4301,8 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) > > 0); > > if (priv_get_ifname(priv, &ifname) == 0) > > info->if_index = if_nametoindex(ifname); > > + info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_40G | > > + ETH_LINK_SPEED_56G; > > priv_unlock(priv); > > } > > Missing: ETH_LINK_SPEED_100M (not sure if we care), ETH_LINK_SPEED_1G and > the nonstandard ETH_LINK_SPEED_20G with some adapters. For v12: - info->speed_capa = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_40G | + info->speed_capa = + ETH_LINK_SPEED_1G | + ETH_LINK_SPEED_10G | + ETH_LINK_SPEED_20G | + ETH_LINK_SPEED_40G | ETH_LINK_SPEED_56G; > In the future we should provide a more accurate speed_capa depending on > actual port capabilities, several mlx4 adapters cannot handle them all. When doing so, you'll be able to fill the row "speed capability" in overview.rst. > > --- a/drivers/net/mlx5/mlx5_ethdev.c > > +++ b/drivers/net/mlx5/mlx5_ethdev.c > > @@ -522,6 +522,9 @@ mlx5_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) > > * size if it is not fixed. > > * The API should be updated to solve this problem. */ > > info->reta_size = priv->ind_table_max_size; > > + info->speed_capa = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G | > > + ETH_LINK_SPEED_25G | ETH_LINK_SPEED_40G | > > + ETH_LINK_SPEED_50G; > > priv_unlock(priv); > > } > > Missing: ETH_LINK_SPEED_100G, ETH_LINK_SPEED_20G and ETH_LINK_SPEED_56G. For v12: - info->speed_capa = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_10G | - ETH_LINK_SPEED_25G | ETH_LINK_SPEED_40G | - ETH_LINK_SPEED_50G | ETH_LINK_SPEED_100G; + info->speed_capa = + ETH_LINK_SPEED_1G | + ETH_LINK_SPEED_10G | + ETH_LINK_SPEED_20G | + ETH_LINK_SPEED_25G | + ETH_LINK_SPEED_40G | + ETH_LINK_SPEED_50G | + ETH_LINK_SPEED_56G | + ETH_LINK_SPEED_100G; ETH_LINK_SPEED_100G is added in patch #8. > Same as above, these capabilities actually depend on the adapter type and > should be probed. > > I think ETH_LINK_SPEED_100M should work as well but I can't find it > mentioned anywhere, let's leave it out for now.