From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 5/8] ring: queue stats mapping set dummy
	implementation
Date: Thu, 09 Jul 2015 03:58:02 +0200
Message-ID: <12941587.YRQEe5TYyV@xps13>
References: <1434723200-7528-1-git-send-email-tomaszx.kulasek@intel.com>
 <1435589444-1988-1-git-send-email-tomaszx.kulasek@intel.com>
 <1435589444-1988-6-git-send-email-tomaszx.kulasek@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 752D55A51
 for <dev@dpdk.org>; Thu,  9 Jul 2015 03:59:08 +0200 (CEST)
Received: by wgjx7 with SMTP id x7so210404582wgj.2
 for <dev@dpdk.org>; Wed, 08 Jul 2015 18:59:08 -0700 (PDT)
In-Reply-To: <1435589444-1988-6-git-send-email-tomaszx.kulasek@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-29 16:50, Tomasz Kulasek:
> Per queue statistics are already implemented for ring device, but with
> static mapping (stat_idx == queue_id).
> 
> This fix is required, if you want to use ring device in test application
> and is used only to point that per queue statistics are provided for this
> device.
> 
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
[...]
> +static int
> +eth_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *dev,
> +		__rte_unused uint16_t queue_id, __rte_unused uint8_t stat_idx,
> +		__rte_unused uint8_t is_rx)
> +{
> +	/* Do nothing, just return ok */
> +	return 0;
> +}

I've just realized how this is broken.
Some Intel devices use a mapping to select hardware queues which will have
some stats. But we may have stats per queues without requiring such mapping.

I may miss something but I suggest these 3 actions:
- remove this patch
- replace checks on stats_mapping by an ethdev flag
- remove device-specific stats_mapping from ethdev