From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751648Ab1AFIZn (ORCPT ); Thu, 6 Jan 2011 03:25:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44352 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160Ab1AFIZm (ORCPT ); Thu, 6 Jan 2011 03:25:42 -0500 From: Amerigo Wang To: linux-kernel@vger.kernel.org Cc: WANG Cong , Eric Biederman , kexec@lists.infradead.org Subject: [Patch] kexec_load: check CAP_SYS_MODULE Date: Thu, 6 Jan 2011 16:25:25 +0800 Message-Id: <1294302325-22593-1-git-send-email-amwang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric pointed out that kexec_load() actually allows you to run any code you want in ring0, this is more like CAP_SYS_MODULE. Reported-by: Eric Paris Signed-off-by: WANG Cong --- diff --git a/kernel/kexec.c b/kernel/kexec.c index b55045b..c30d613 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -945,7 +945,7 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments, int result; /* We only trust the superuser with rebooting the system. */ - if (!capable(CAP_SYS_BOOT)) + if (!capable(CAP_SYS_BOOT) || !capable(CAP_SYS_MODULE)) return -EPERM; /* From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PalAD-0000EI-8I for kexec@lists.infradead.org; Thu, 06 Jan 2011 08:25:42 +0000 From: Amerigo Wang Subject: [Patch] kexec_load: check CAP_SYS_MODULE Date: Thu, 6 Jan 2011 16:25:25 +0800 Message-Id: <1294302325-22593-1-git-send-email-amwang@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org, WANG Cong , Eric Biederman Eric pointed out that kexec_load() actually allows you to run any code you want in ring0, this is more like CAP_SYS_MODULE. Reported-by: Eric Paris Signed-off-by: WANG Cong --- diff --git a/kernel/kexec.c b/kernel/kexec.c index b55045b..c30d613 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -945,7 +945,7 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments, int result; /* We only trust the superuser with rebooting the system. */ - if (!capable(CAP_SYS_BOOT)) + if (!capable(CAP_SYS_BOOT) || !capable(CAP_SYS_MODULE)) return -EPERM; /* _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec