* [PATCH 3/4] sparc: Add pci32_unmap_page.
@ 2011-01-11 10:49 Kristoffer Glembo
2011-01-13 2:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kristoffer Glembo @ 2011-01-11 10:49 UTC (permalink / raw)
To: sparclinux
Signed-off-by: Kristoffer Glembo <kristoffer@gaisler.com>
---
arch/sparc/kernel/ioport.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/arch/sparc/kernel/ioport.c b/arch/sparc/kernel/ioport.c
index bfcbd1e..ba5cf62 100644
--- a/arch/sparc/kernel/ioport.c
+++ b/arch/sparc/kernel/ioport.c
@@ -529,6 +529,14 @@ static dma_addr_t pci32_map_page(struct device *dev, struct page *page,
return page_to_phys(page) + offset;
}
+static void pci32_unmap_page(struct device *dev, dma_addr_t ba, size_t size,
+ enum dma_data_direction dir, struct dma_attrs *attrs)
+{
+ if (dir != PCI_DMA_TODEVICE) {
+ mmu_inval_dma_area((unsigned long)phys_to_virt(ba), PAGE_ALIGN(size));
+ }
+}
+
/* Map a set of buffers described by scatterlist in streaming
* mode for DMA. This is the scather-gather version of the
* above pci_map_single interface. Here the scatter gather list
@@ -651,6 +659,7 @@ struct dma_map_ops pci32_dma_ops = {
.alloc_coherent = pci32_alloc_coherent,
.free_coherent = pci32_free_coherent,
.map_page = pci32_map_page,
+ .unmap_page = pci32_unmap_page,
.map_sg = pci32_map_sg,
.unmap_sg = pci32_unmap_sg,
.sync_single_for_cpu = pci32_sync_single_for_cpu,
--
1.6.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/4] sparc: Add pci32_unmap_page.
2011-01-11 10:49 [PATCH 3/4] sparc: Add pci32_unmap_page Kristoffer Glembo
@ 2011-01-13 2:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-01-13 2:33 UTC (permalink / raw)
To: sparclinux
From: Kristoffer Glembo <kristoffer@gaisler.com>
Date: Tue, 11 Jan 2011 11:49:05 +0100
> Signed-off-by: Kristoffer Glembo <kristoffer@gaisler.com>
> ---
> arch/sparc/kernel/ioport.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/sparc/kernel/ioport.c b/arch/sparc/kernel/ioport.c
> index bfcbd1e..ba5cf62 100644
> --- a/arch/sparc/kernel/ioport.c
> +++ b/arch/sparc/kernel/ioport.c
> @@ -529,6 +529,14 @@ static dma_addr_t pci32_map_page(struct device *dev, struct page *page,
> return page_to_phys(page) + offset;
> }
>
> +static void pci32_unmap_page(struct device *dev, dma_addr_t ba, size_t size,
> + enum dma_data_direction dir, struct dma_attrs *attrs)
> +{
> + if (dir != PCI_DMA_TODEVICE) {
> + mmu_inval_dma_area((unsigned long)phys_to_virt(ba), PAGE_ALIGN(size));
> + }
> +}
> +
Please do not enclose a basic block consisting of one single statement
into braces.
Fix this up for all of your patches and resubmit.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-13 2:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-11 10:49 [PATCH 3/4] sparc: Add pci32_unmap_page Kristoffer Glembo
2011-01-13 2:33 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.