From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
Subject: Re: xl and GFX passthrough
Date: Thu, 13 Jan 2011 10:24:42 +0000
Message-ID: <1294914282.8240.38.camel@zakaz.uk.xensource.com>
References: <4D2EC20D.2050603@gmail.com>
	<1294910794.8240.9.camel@zakaz.uk.xensource.com>
	<4D2ECE5A.8070807@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4D2ECE5A.8070807@gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Sergey Tovpeko <tsv.devel@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2011-01-13 at 10:05 +0000, Sergey Tovpeko wrote:
> Ian Campbell wrote:
> >
> >
> > I think gfx_passthrough is actually a boolean, right? In that case it
> > should be declared as "bool" in the idl.
> >   
> 
> Well, the integer value of gfx_passthru had meaning in 2009, I suspect. 
> It differentiated between IGD adapter and discrete adapter.
> http://xen.1045712.n5.nabble.com/PATCH-0-2-v2-graphics-passthrough-with-VT-d-td2534811.html
> 
> At now, I didn't notice integer meaning of this variable in the code. I 
> changed it to bool in the new patch.

I just noticed that this appears to have been fixed by Daniel De Graf
just a few days ago, see 22711:4f6fee3a456e, which may only be in the
staging tree at http://xenbits.xen.org/staging/xen-unstable.hg since we
are waiting for a test pass.

Ian.